From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A80C63858D35 for ; Tue, 10 Oct 2023 14:55:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A80C63858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696949718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=88CZ7+Q18mEqBm5IwD2tP+krbPDXp4RSX+n2YIGmxHc=; b=ahAeJDfhmqaqD7aq1Zy0EUPG5ty628ulp0hhZ5tKee031SkqYztAXzHiOgTkHi0JsBkQWZ DzVh25D7E1f0X38x/cSdS6U6A6Cs4AGLsDulbdbHQLWNCmbdBaIxjJC8CMMfttnQEDUEYw 0q84AnUbnV+gvbEpTKPaktILMZBMuWU= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-49-pKc263__Nhuep0QmAUX94Q-1; Tue, 10 Oct 2023 10:55:16 -0400 X-MC-Unique: pKc263__Nhuep0QmAUX94Q-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-533c6d0b377so4921086a12.3 for ; Tue, 10 Oct 2023 07:55:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696949715; x=1697554515; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=88CZ7+Q18mEqBm5IwD2tP+krbPDXp4RSX+n2YIGmxHc=; b=pY6IVTO5Wq8w+Z0/W3kiFcJ6XAsr0/psVtv8EnGbls7QJdRh5Cn4ooJd3w2yhuyXEf n4iwkK0orAsPEX2I3QZwb8be/mfLSRlBKd1XV58RKgNoce837d+IHdBWngrsJwW54xsn p0F/xN0yxxAkAtHsFeiTp8VD8N4G6EfH24sslMHc5MDtpUFlkF3V7G0ibQF0qxEriefe l9nBlBffIHC1VqlX4LDi1O2MrO1lJuq3MU+rf1YBUqWQnfd/rVm+iNyqNBYPEX9t4oZs 6UaZU4ZFnu+IoIC6aSlU9NkIcA8+XPoSkK/2apZH8kuyZItZTv4nKKT13uPNBfS5jNo7 geqw== X-Gm-Message-State: AOJu0YyYnLb6yAO2Kd1raQLqQJL6tVqj0L1mJnTCrrK/Q1Wyiq3e79yI NH0xPuqBArJpJ54BbGZUK0mR1GqOMRSaKPQGnuGLkgM9lGjRjeMmrcprIhDc3WjtHRWSvvfVkVQ IWDtwv7JCHp7PSvNyjBkt15nO7Rzdtw== X-Received: by 2002:aa7:d64b:0:b0:530:a19b:175 with SMTP id v11-20020aa7d64b000000b00530a19b0175mr16832499edr.2.1696949715213; Tue, 10 Oct 2023 07:55:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH8W+RcPyNayi62DSdpGkCa7WbpHl1+TmJnoNGpsZYX7uavpNCrzXJAqoKprO4jximrJ5sFeQ== X-Received: by 2002:aa7:d64b:0:b0:530:a19b:175 with SMTP id v11-20020aa7d64b000000b00530a19b0175mr16832462edr.2.1696949714645; Tue, 10 Oct 2023 07:55:14 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id d2-20020a056402078200b0053691cacd95sm7777080edy.87.2023.10.10.07.55.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 07:55:14 -0700 (PDT) Message-ID: <527da2f6-1d6b-306d-4c29-3184fcf3132b@redhat.com> Date: Tue, 10 Oct 2023 16:55:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/5] Various inferior / arch cleanups To: Simon Marchi , John Baldwin , gdb-patches@sourceware.org References: <20230929182541.138320-1-simon.marchi@efficios.com> <0b4cad10-dc87-6645-e397-18f26c9f04dc@FreeBSD.org> <75ee7957-e049-4105-940d-3b8d4c334f4d@efficios.com> From: Guinevere Larsen In-Reply-To: <75ee7957-e049-4105-940d-3b8d4c334f4d@efficios.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/10/2023 16:43, Simon Marchi wrote: > On 10/6/23 18:05, John Baldwin wrote: >> On 9/29/23 2:24 PM, Simon Marchi via Gdb-patches wrote: >>> I'm in the middle of a bigger change, moving things around, and >>> extracted these patches which make sense on their own, I think. No >>> changes in behavior expected. >>> >>> Simon Marchi (5): >>> gdb: add inferior::{arch, set_arch} >>> gdb: add inferior parameter to architecture_changed observable >>> gdb: move set_target_gdbarch to inferior::set_arch >>> gdb: remove target_gdbarch >>> gdb: scope down registers_changed call in inferior::set_arch >>> >>> gdb/aarch64-linux-nat.c | 14 ++-- >>> gdb/ada-lang.c | 7 +- >>> gdb/ada-tasks.c | 9 +-- >>> gdb/aix-thread.c | 5 +- >>> gdb/amd-dbgapi-target.c | 4 +- >>> gdb/amd64-linux-nat.c | 2 +- >>> gdb/arc-tdep.c | 5 +- >>> gdb/arch-utils.c | 31 +++------ >>> gdb/arm-fbsd-tdep.c | 2 +- >>> gdb/arm-tdep.c | 15 ++-- >>> gdb/auxv.c | 21 +++--- >>> gdb/break-catch-syscall.c | 2 +- >>> gdb/breakpoint.c | 16 ++--- >>> gdb/bsd-uthread.c | 15 ++-- >>> gdb/btrace.c | 3 +- >>> gdb/cli/cli-dump.c | 5 +- >>> gdb/compile/compile-c-symbols.c | 12 ++-- >>> gdb/compile/compile-cplus-symbols.c | 12 ++-- >>> gdb/compile/compile-object-load.c | 52 +++++++------- >>> gdb/corefile.c | 3 +- >>> gdb/corelow.c | 2 +- >>> gdb/cp-namespace.c | 3 +- >>> gdb/cp-support.c | 3 +- >>> gdb/d-namespace.c | 3 +- >>> gdb/darwin-nat-info.c | 12 ++-- >>> gdb/dcache.c | 6 +- >>> gdb/disasm.c | 11 +-- >>> gdb/elfread.c | 4 +- >>> gdb/fbsd-nat.c | 2 +- >>> gdb/filesystem.c | 3 +- >>> gdb/frame-unwind.c | 3 +- >>> gdb/gcore-elf.c | 2 +- >>> gdb/gcore.c | 49 ++++++------- >>> gdb/gdbarch.h | 24 +------ >>> gdb/gnu-nat.c | 6 +- >>> gdb/i386-darwin-nat.c | 8 +-- >>> gdb/i386-tdep.c | 6 +- >>> gdb/ia64-vms-tdep.c | 2 +- >>> gdb/infcmd.c | 8 +-- >>> gdb/inferior.c | 19 ++++- >>> gdb/inferior.h | 33 +++++---- >>> gdb/infrun.c | 19 ++--- >>> gdb/jit.c | 5 +- >>> gdb/linux-nat.c | 10 +-- >>> gdb/linux-tdep.c | 6 +- >>> gdb/memattr.c | 9 +-- >>> gdb/mep-tdep.c | 4 +- >>> gdb/mi/mi-interp.c | 8 +-- >>> gdb/mi/mi-main.c | 2 +- >>> gdb/microblaze-tdep.c | 2 +- >>> gdb/mips-linux-nat.c | 6 +- >>> gdb/mips-linux-tdep.c | 5 +- >>> gdb/mips-tdep.c | 15 ++-- >>> gdb/moxie-tdep.c | 4 +- >>> gdb/msp430-tdep.c | 3 +- >>> gdb/netbsd-nat.c | 2 +- >>> gdb/nto-procfs.c | 5 +- >>> gdb/nto-tdep.c | 29 ++++---- >>> gdb/observable.h | 5 +- >>> gdb/ppc-linux-nat.c | 2 +- >>> gdb/ppc-linux-tdep.c | 2 +- >>> gdb/printcmd.c | 66 +++++++++--------- >>> gdb/proc-service.c | 2 +- >>> gdb/process-stratum-target.c | 2 +- >>> gdb/process-stratum-target.h | 3 +- >>> gdb/procfs.c | 24 ++++--- >>> gdb/progspace.c | 10 +-- >>> gdb/python/py-finishbreakpoint.c | 2 +- >>> gdb/python/py-inferior.c | 16 ++--- >>> gdb/python/py-objfile.c | 5 +- >>> gdb/python/py-progspace.c | 5 +- >>> gdb/python/py-record-btrace.c | 2 +- >>> gdb/python/py-unwind.c | 2 +- >>> gdb/python/python.c | 4 +- >>> gdb/ravenscar-thread.c | 7 +- >>> gdb/record-btrace.c | 2 +- >>> gdb/record-full.c | 19 +++-- >>> gdb/regcache-dump.c | 6 +- >>> gdb/regcache.c | 8 +-- >>> gdb/remote-sim.c | 2 +- >>> gdb/remote.c | 73 +++++++++++--------- >>> gdb/rl78-tdep.c | 6 +- >>> gdb/rs6000-aix-nat.c | 5 +- >>> gdb/rs6000-tdep.c | 2 +- >>> gdb/rust-parse.c | 5 +- >>> gdb/rx-tdep.c | 5 +- >>> gdb/s390-linux-nat.c | 2 +- >>> gdb/scoped-mock-context.h | 2 +- >>> gdb/sol-thread.c | 13 ++-- >>> gdb/solib-darwin.c | 30 ++++---- >>> gdb/solib-dsbt.c | 26 +++---- >>> gdb/solib-frv.c | 19 ++--- >>> gdb/solib-rocm.c | 2 +- >>> gdb/solib-svr4.c | 88 ++++++++++++++---------- >>> gdb/solib.c | 37 +++++----- >>> gdb/sparc64-tdep.c | 14 ++-- >>> gdb/symfile-mem.c | 4 +- >>> gdb/symfile.c | 11 +-- >>> gdb/symtab.c | 6 +- >>> gdb/target-descriptions.c | 4 +- >>> gdb/target.c | 33 +++++---- >>> gdb/target.h | 2 +- >>> gdb/tracefile-tfile.c | 25 ++++--- >>> gdb/tracefile.c | 3 +- >>> gdb/tracepoint.c | 31 ++++----- >>> gdb/tui/tui-disasm.c | 2 +- >>> gdb/unittests/frame_info_ptr-selftests.c | 2 +- >>> gdb/value.c | 4 +- >>> gdb/windows-nat.c | 2 +- >>> gdb/windows-tdep.c | 10 +-- >>> gdb/z80-tdep.c | 2 +- >>> 111 files changed, 667 insertions(+), 577 deletions(-) >>> >>> >>> base-commit: 4ebfd53de03599b73838ee339e47652ac26c37c0 >> I only skimmed these, but these seem ok to me in principle. > Thanks, will add your Reviewed-By. > > I don't think we have a tag for "I gave it a quick look and I think it > makes sense, I thought that's what Acked-By was for, but the definition > we're about to put in MAINTAINERS is different, so I'll stick with > Reviewed-By even if it's not a thorough review. > Not to hijack this thread too much, but Kevin agrees with you that Acked-By should be used in these cases, and said so in the relevant thread. This is still under discussion, if you want to give your opinion -- Cheers, Guinevere Larsen She/Her/Hers