From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30500 invoked by alias); 20 Nov 2013 13:23:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30357 invoked by uid 89); 20 Nov 2013 13:23:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2013 13:23:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAKDMu13010113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 20 Nov 2013 08:22:57 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAKDMsaW006347; Wed, 20 Nov 2013 08:22:55 -0500 Message-ID: <528CB7AE.1060601@redhat.com> Date: Wed, 20 Nov 2013 13:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Agovic, Sanimir" CC: "'Tom Tromey'" , "gdb-patches@sourceware.org" Subject: Re: [PATCH 05/10] vla: allow side effects for sizeof argument References: <1382366424-21010-1-git-send-email-sanimir.agovic@intel.com> <1382366424-21010-6-git-send-email-sanimir.agovic@intel.com> <87d2mua1gi.fsf@fleche.redhat.com> <0377C58828D86C4588AEEC42FC3B85A71769F292@IRSMSX105.ger.corp.intel.com> <87ppqp9kme.fsf@fleche.redhat.com> <0377C58828D86C4588AEEC42FC3B85A7176B5F16@IRSMSX105.ger.corp.intel.com> <528B9A5F.5020706@redhat.com> <0377C58828D86C4588AEEC42FC3B85A7176B8275@IRSMSX105.ger.corp.intel.com> In-Reply-To: <0377C58828D86C4588AEEC42FC3B85A7176B8275@IRSMSX105.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00596.txt.bz2 On 11/20/2013 12:17 PM, Agovic, Sanimir wrote: >> Sounds like something that the testsuite should have caught. >> I guess we don't have such a test? >> > No yet, see below. > > test: test eval routines with EVAL_AVOID_SIDE_EFFECTS flag set > > Ensure that certain commands (e.g. whatis/ptype) and sizeof intrinsic > have no side effects (variables cannot be altered). > > 2013-11-20 Sanimir Agovic > > testsuite/ > * gdb.base/eval-avoid-side-effects.exp: New test. Excellent! Thanks, this is OK. -- Pedro Alves