From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34252 invoked by alias); 5 Jun 2018 21:03:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34240 invoked by uid 89); 5 Jun 2018 21:03:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=2018-05-03, 20180503 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Jun 2018 21:03:43 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w55L3bTu009541 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 5 Jun 2018 17:03:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 5545F1E530; Tue, 5 Jun 2018 17:03:37 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id DB8DC1E4F7; Tue, 5 Jun 2018 17:03:36 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 Jun 2018 21:03:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 4/6] Introduce accessors for psymtab high and low fields In-Reply-To: <20180503223621.22544-5-tom@tromey.com> References: <20180503223621.22544-1-tom@tromey.com> <20180503223621.22544-5-tom@tromey.com> Message-ID: <528f8ccae78d04fff0b1188f943cc884@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 5 Jun 2018 21:03:37 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00128.txt.bz2 On 2018-05-03 18:36, Tom Tromey wrote: > This introduces accessors for the partial symbol table textlow and > texthigh fields. This lets us later arrange to relocate these values > at their point of use. > > I did this conversion by renaming the fields. I didn't rename the > fields back afterward, thinking that on the off chance that someone > has a patch touching this area, then a merge would helpfully break > their compile. Good idea to rename the field. What do you think of renaming them to text_low/text_high instead? Like in the previous patches, it would be nice to make the new accessors functions instead of macros. Instead of adding "old school" accessors, another choice would have been to introduce methods instead and make those fields private. Simon