From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8920 invoked by alias); 29 Nov 2013 15:11:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8909 invoked by uid 89); 29 Nov 2013 15:11:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Nov 2013 15:11:06 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rATFAt7g019598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Nov 2013 10:10:55 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rATFArXD009668; Fri, 29 Nov 2013 10:10:54 -0500 Message-ID: <5298AE7C.6020607@redhat.com> Date: Fri, 29 Nov 2013 16:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet References: <5265022F.8060203@mentor.com> <52654A2C.9010202@redhat.com> <529707C7.4040504@mentor.com> In-Reply-To: <529707C7.4040504@mentor.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-11/txt/msg00937.txt.bz2 On 11/28/2013 09:07 AM, Hui Zhu wrote: > + if (have_target_target_side_commands) This can now just be: if (!VEC_empty (agent_expr_p, bp_tgt->tcommands)) OK with that change. > + { > + warning (_("\ > +Target doesn't support breakpoints that have target side commands.")); I was doing to suggest making this an error instead, that insert_bp_location would print the error string, but that's only true for hw breakpoints... insert_bp_location's error handling is quite messy. For instance, if this breakpoint is in a a shared library, this will disable the breakpoint, even though the cause of the error is clearly not that the shared library disappeared (i.e., not a memory error). > + return -1; > + } -- Pedro Alves