From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2548 invoked by alias); 2 Dec 2013 04:46:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2505 invoked by uid 89); 2 Dec 2013 04:46:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Dec 2013 04:46:10 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VnLOL-00033X-38 from ChungLin_Tang@mentor.com ; Sun, 01 Dec 2013 20:45:53 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 1 Dec 2013 20:45:52 -0800 Received: from air.local (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Sun, 1 Dec 2013 20:45:52 -0800 Message-ID: <529C107E.10308@codesourcery.com> Date: Mon, 02 Dec 2013 04:46:00 -0000 From: Chung-Lin Tang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Joel Brobecker CC: , Sandra Loosemore Subject: Re: [patch, nios2] Update Linux parts for new syscall ABI References: <529AF143.9060704@codesourcery.com> <20131202032333.GN3114@adacore.com> In-Reply-To: <20131202032333.GN3114@adacore.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00012.txt.bz2 On 13/12/2 11:23 AM, Joel Brobecker wrote: >> This patch updates the nios2-linux code for the new Linux generic system >> call interface. Mainly removing (non-rt) sigreturn related definitions, >> and updating the rt_sigreturn syscall NR. >> >> Will commit after Sandra's approval. > > I am sorry to be so procedural, but while Sandra input would probably > be more valuable than most, Sandra is not yet listed as maintainer > in GDB. She can therefore not approve patches for commit in the official > repository yet. It should all be documented in gdb/MAINTAINERS. Is Sandra not nios2 maintainer, or is she just not yet added to the MAINTAINERS file? >> 2013-12-01 Chung-Lin Tang >> >> gdb/ >> * nios2-linux-tdep.c (nios2_linux_sigreturn_init): Remove. >> (nios2_linux_sigreturn_tramp_frame): Remove. >> (nios2_linux_rt_sigreturn_tramp_frame): Update rt_sigreturn syscall >> number. >> (nios2_linux_syscall_next_pc): Likewise. Remove sigreturn case. >> (nios2_linux_init_abi): >> Remove registration of nios2_linux_sigreturn_tramp_frame. > > My concern with your patch is that it seems to eliminate support for > the previous syscall ABI, which means a break in compatibility. Unless > we really have no other choice, I don't think we would want that. This is a coordinated change, Altera will be using the new syscall ABI when they upstream the kernel port. Thanks, Chung-Lin