From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12273 invoked by alias); 3 Dec 2013 04:50:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12261 invoked by uid 89); 3 Dec 2013 04:50:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_40,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2013 04:50:18 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Vnhvu-0006Ii-A6 from Hui_Zhu@mentor.com ; Mon, 02 Dec 2013 20:50:02 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 2 Dec 2013 20:50:02 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Mon, 2 Dec 2013 20:49:50 -0800 Message-ID: <529D62F7.80701@mentor.com> Date: Tue, 03 Dec 2013 04:50:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches ml Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet References: <5265022F.8060203@mentor.com> <52654A2C.9010202@redhat.com> <529707C7.4040504@mentor.com> <5298AE7C.6020607@redhat.com> <529C80D2.2080608@mentor.com> <529C9B42.20600@redhat.com> In-Reply-To: <529C9B42.20600@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00059.txt.bz2 On 12/02/13 22:37, Pedro Alves wrote: > On 12/02/2013 12:45 PM, Hui Zhu wrote: >> On 11/29/13 23:10, Pedro Alves wrote: >>>> On 11/28/2013 09:07 AM, Hui Zhu wrote: >>>> >>>>>> + if (have_target_target_side_commands) >>>> >>>> This can now just be: >>>> >>>> if (!VEC_empty (agent_expr_p, bp_tgt->tcommands)) >>>> >>>> OK with that change. >>>> >>>>>> + { >>>>>> + warning (_("\ >>>>>> +Target doesn't support breakpoints that have target side commands.")); >>>> >>>> I was doing to suggest making this an error instead, that >>>> insert_bp_location would print the error string, but that's >>>> only true for hw breakpoints... insert_bp_location's error >>>> handling is quite messy. For instance, if this breakpoint >>>> is in a a shared library, this will disable the breakpoint, >>>> even though the cause of the error is clearly not that the >>>> shared library disappeared (i.e., not a memory error). >>>> >>>>>> + return -1; >>>>>> + } >> Updated the patch according to your comments. > > But you switched to "error" anyway? Above I was saying that I > was going that suggest it, but then explained why I didn't think > it would work. Was I wrong? The reason is insert_bp_location doesn't have code to handle this error. I make a new patch that include this code. Please help me review it. > >> >> And I make a patch for dprintf.exp and mi-dprintf.exp to make test OK on the target that doesn't support "Zx" packets. >> >> The patches were tested and pass regression test on X86_64 and PPC. > > (It's best to stick to one patch per email, otherwise things > end up confusing. I suggest looking into git send-email.) > OK. I will post new version of this patch in another mail. Thanks, Hui 2013-12-03 Hui Zhu PR gdb/16101 * breakpoint.c (insert_bp_location): output error message of software breakpoints. * remote.c (remote_insert_breakpoint): If this breakpoint has target-side commands but this stub doesn't support Z0 packets, throw error. --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -2588,6 +2588,12 @@ insert_bp_location (struct bp_location * if (hw_bp_err_string) fprintf_unfiltered (tmp_error_stream, "%s.\n", hw_bp_err_string); } + else if (hw_bp_err_string != NULL) + { + fprintf_unfiltered (tmp_error_stream, + "Cannot insert breakpoint %d:%s\n", + bl->owner->number, hw_bp_err_string); + } else { char *message = memory_error_message (TARGET_XFER_E_IO, --- a/gdb/remote.c +++ b/gdb/remote.c @@ -8244,6 +8244,12 @@ remote_insert_breakpoint (struct gdbarch } } + /* If this breakpoint has target-side commands but this stub doesn't + support Z0 packets, throw error. */ + if (!VEC_empty (agent_expr_p, bp_tgt->tcommands)) + error (_("\ +Target doesn't support breakpoints that have target side commands.")); + return memory_insert_breakpoint (gdbarch, bp_tgt); }