From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D261A3858C60 for ; Thu, 1 Dec 2022 18:29:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D261A3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 29F921E0D3; Thu, 1 Dec 2022 13:29:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669919394; bh=5J8VuLp/nyUwTUWcYd+EBmXUcW25iQBFRUnoRKo6V5E=; h=Date:Subject:To:References:From:In-Reply-To:From; b=OsMpY7r7tbV3ZfaswfFcsOwo77yhqGcjjbgc2/9anAc+kg6lK1RzAwG5oN2cFd6/U UE0jHIoG+KbbyTM2q0NltmPYkAslHXO4g1L+yUZQUO/HepEADbGQhYVZQjrDrAmlvZ 5i3BXL7vdDn0v8XX3pQGAv4lf6TRJZN1Hpn/Cqng= Message-ID: <529be10d-bc31-1948-9743-ec374284b197@simark.ca> Date: Thu, 1 Dec 2022 13:29:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] Remove the_windows_nat_target global Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20221130155207.2444224-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20221130155207.2444224-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/30/22 10:52, Tom Tromey via Gdb-patches wrote: > I belatedly realized that the "the_windows_nat_target" global isn't > really necessary. It's only used in one place, where 'this' would be > simpler and clearer. This patch removes the global entirely. This LGTM: Approved-By: Simon Marchi Simon