From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] "tfind" across unavailable-stack frames.
Date: Sat, 14 Dec 2013 06:23:00 -0000 [thread overview]
Message-ID: <52ABF8D7.1050805@codesourcery.com> (raw)
In-Reply-To: <52AB48B6.6040206@redhat.com>
On 12/14/2013 01:49 AM, Pedro Alves wrote:
> gdb/
> 2013-12-13 Pedro Alves <palves@redhat.com>
>
> * frame.h (enum frame_id_stack_status): New enum.
> (struct frame_id) <stack_addr>: Adjust comment.
> <stack_addr_p>: Delete field, replaced with ...
> <stack_status>: ... this new field.
> (frame_id_build_unavailable_stack): Declare.
> * frame.c (frame_addr_hash, fprint_field, outer_frame_id)
> (frame_id_build_special): Adjust.
> (frame_id_build_unavailable_stack): New function.
> (frame_id_build, frame_id_build_wild): Adjust.
> (frame_id_p, frame_id_eq, frame_id_inner): Adjust to take into
> account frames with unavailable stack.
>
> * amd64-tdep.c (amd64_frame_this_id)
> (amd64_sigtramp_frame_this_id, amd64_epilogue_frame_this_id): Use
> frame_id_build_unavailable_stack.
> * dwarf2-frame.c (dwarf2_frame_this_id): Likewise.
Do we need to update tailcall_frame_this_id as well? I can't find an
easy way to reproduce it on tailcall frame (using
gdb.arch/amd64-tailcall-* cases).
Patch looks right to me, two nits on comments below,
> @@ -169,6 +187,12 @@ extern struct frame_id frame_id_build_special (CORE_ADDR stack_addr,
> CORE_ADDR code_addr,
> CORE_ADDR special_addr);
>
> +/* Construct a frame ID representing a frame where the stack address
> + exists, but is unavailable. The first parameter is the frame's
Remove "first"? since we only have one parameter here.
> + constant code address (typically the entry point). The special
> + identifier address is set to indicate a wild card. */
> +extern struct frame_id frame_id_build_unavailable_stack (CORE_ADDR code_addr);
> +
What does the last sentence mean in the comments?
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-12-14 6:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 18:26 [patch] circ.exp Abid, Hafiz
2013-04-11 22:59 ` Abid, Hafiz
2013-04-16 7:52 ` Pedro Alves
2013-04-16 20:53 ` Abid, Hafiz
2013-04-17 20:33 ` Pedro Alves
2013-04-17 20:54 ` Abid, Hafiz
2013-04-18 10:30 ` Pedro Alves
2013-04-18 11:09 ` Pedro Alves
2013-12-13 17:49 ` [PATCH] "tfind" across unavailable-stack frames Pedro Alves
2013-12-14 6:23 ` Yao Qi [this message]
2013-12-16 16:19 ` Pedro Alves
2013-12-17 9:04 ` Yao Qi
2013-12-17 10:09 ` Pedro Alves
2013-12-17 12:39 ` Yao Qi
2013-12-17 20:55 ` Pedro Alves
2013-12-16 8:40 ` Metzger, Markus T
2013-12-16 16:25 ` Pedro Alves
2013-12-16 16:42 ` [PATCH v2] " Pedro Alves
2013-04-19 14:27 ` [patch] circ.exp Abid, Hafiz
2013-04-19 14:28 ` Pedro Alves
2013-05-08 10:12 ` Abid, Hafiz
2013-05-08 15:13 ` Pedro Alves
2013-05-08 16:18 ` Abid, Hafiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ABF8D7.1050805@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).