From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5460 invoked by alias); 16 Dec 2013 17:13:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5445 invoked by uid 89); 16 Dec 2013 17:12:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2013 17:12:58 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBGHCrHx005966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Dec 2013 12:12:53 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBGHCpAm023910; Mon, 16 Dec 2013 12:12:52 -0500 Message-ID: <52AF3493.9090708@redhat.com> Date: Mon, 16 Dec 2013 17:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [RFA] Fix cygwin compilation failure due to nameless LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing References: <52ab8d0e.8aa2420a.30ff.ffffd8f1SMTPIN_ADDED_BROKEN@mx.google.com> In-Reply-To: <52ab8d0e.8aa2420a.30ff.ffffd8f1SMTPIN_ADDED_BROKEN@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00584.txt.bz2 On 12/13/2013 10:37 PM, Pierre Muller wrote: > Following this thread > https://sourceware.org/ml/gdb-patches/2013-12/msg00073.html > > The patch > https://sourceware.org/ml/gdb-cvs/2013-12/msg00054.html > > introduced a failure for cygwin native build. > The problem is that __USEWIDE is not considered in the patch. > > The patch below fixes this compilation error > and should allow cygwin to work as mingw. Looks fine to me. (Though I wonder why not just use GetModuleFileNameExA explicitly. In fact, it's what gdbserver does). -- Pedro Alves