From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
gdb-patches@sourceware.org
Subject: Re: [RFA] Fix cygwin compilation failure due to nameless LOAD_DLL_DEBUG_EVENT causes ntdll.dll to be missing
Date: Mon, 16 Dec 2013 18:05:00 -0000 [thread overview]
Message-ID: <52AF40E4.1020709@redhat.com> (raw)
In-Reply-To: <52AE633E.9020604@codesourcery.com>
On 12/16/2013 02:19 AM, Yao Qi wrote:
> GetModuleFileNameEx is also used in get_module_name, so probably we can
> copy its pattern here too
>
> #ifdef __CYGWIN__
> len = GetModuleFileNameEx (current_process_handle, DllHandle,
> pathbuf, __PMAX);
> if (cygwin_conv_path (CCP_WIN_W_TO_POSIX, pathbuf, dll_name_ret,
> __PMAX) < 0)
> ...
> #else
> len = GetModuleFileNameEx (current_process_handle,
> DllHandle, dll_name_ret, __PMAX);
> #endif
>
> and code is more consistent on using GetModuleFileNameEx.
At this level we're thinking in terms of Win32 debug API, and
it's irrelevant what Cygwin thinks is the Posix path of
ntdll.dll. If this is indeed ntdll.dll, then the following
windows_make_so call will then do that conversion before
recording the dll name.
--
Pedro Alves
next prev parent reply other threads:[~2013-12-16 18:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 22:41 Pierre Muller
2013-12-16 2:21 ` Yao Qi
2013-12-16 18:05 ` Pedro Alves [this message]
2013-12-17 0:43 ` Yao Qi
2013-12-17 8:43 ` Pierre Muller
2013-12-18 3:37 ` Yao Qi
[not found] <52ab8d0e.8aa2420a.30ff.ffffd8f1SMTPIN_ADDED_BROKEN@mx.google.com>
2013-12-16 17:13 ` Pedro Alves
2013-12-16 22:50 ` Pierre Muller
2013-12-18 11:20 ` Corinna Vinschen
2013-12-18 15:46 ` Eli Zaretskii
2013-12-18 16:07 ` Corinna Vinschen
2013-12-18 17:03 ` Eli Zaretskii
2013-12-18 17:18 ` Corinna Vinschen
2013-12-18 17:29 ` Eli Zaretskii
2013-12-18 17:31 ` Corinna Vinschen
2013-12-18 18:19 ` Eli Zaretskii
2013-12-18 19:18 ` Corinna Vinschen
2013-12-18 20:01 ` Eli Zaretskii
2013-12-18 20:54 ` Corinna Vinschen
2013-12-19 18:33 ` Eli Zaretskii
2013-12-28 3:17 ` Joel Brobecker
2013-12-28 9:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF40E4.1020709@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).