From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5895 invoked by alias); 19 Dec 2013 19:08:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5886 invoked by uid 89); 19 Dec 2013 19:08:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2013 19:08:39 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJJ8avW001526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Dec 2013 14:08:37 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBJJ8YuQ024268; Thu, 19 Dec 2013 14:08:35 -0500 Message-ID: <52B34432.20408@redhat.com> Date: Thu, 19 Dec 2013 19:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v9 20/29] target, breakpoint: allow insert/remove breakpoint to be forwarded References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-21-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1387471499-29444-21-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00797.txt.bz2 On 12/19/2013 04:44 PM, Markus Metzger wrote: > static int > -record_full_insert_breakpoint (struct gdbarch *gdbarch, > +record_full_insert_breakpoint (struct target_ops *ops, > + struct gdbarch *gdbarch, > struct bp_target_info *bp_tgt) > { > struct record_full_breakpoint *bp; > @@ -1762,7 +1765,8 @@ record_full_insert_breakpoint (struct gdbarch *gdbarch, > int ret; > > old_cleanups = record_full_gdb_operation_disable_set (); > - ret = record_full_beneath_to_insert_breakpoint (gdbarch, bp_tgt); > + ret = record_full_beneath_to_insert_breakpoint (ops->beneath, gdbarch, Pedantically, this shouldn't be ops->beneath (until Tromey's series is done). You'll need to record the right ops in record_full_open (like e.g., tmp_to_resume_ops). > +int > +forward_target_remove_breakpoint (struct target_ops *ops, > + struct gdbarch *gdbarch, > + struct bp_target_info *bp_tgt) > +{ This is quite like Tromey's original target_delegate_... functions in the target-async series. Oh well, let's proceed, and it'll end up redone when Tromey's done. Please leave the may_insert_breakpoint checks not in the forward function, but still in target_remote|insert_breakpoint. No need to redo that check at each forward while traversing the target stack. -- Pedro Alves