From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9728 invoked by alias); 19 Dec 2013 19:13:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9719 invoked by uid 89); 19 Dec 2013 19:13:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2013 19:13:32 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJJDUAN008133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Dec 2013 14:13:30 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBJJDPt8016477; Thu, 19 Dec 2013 14:13:29 -0500 Message-ID: <52B34555.8040200@redhat.com> Date: Thu, 19 Dec 2013 19:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v9 21/29] record-btrace: provide xfer_partial target method References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-22-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1387471499-29444-22-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00799.txt.bz2 On 12/19/2013 04:44 PM, Markus Metzger wrote: > + > + /* We do not allow writing memory in general. */ > + if (writebuf != NULL) > + throw_error (NOT_AVAILABLE_ERROR, > + _("This record target does not record memory.")); So printing globals errors out? I thought you were going to return TARGET_XFER_E_UNAVAILABLE anyway? Did you try making raw_memory_xfer_partial return immediately if ops->to_xfer_partial returns TARGET_XFER_E_UNAVAILABLE, instead of proceeding to query the target beneath? -- Pedro Alves