From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19869 invoked by alias); 19 Dec 2013 19:26:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19857 invoked by uid 89); 19 Dec 2013 19:26:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2013 19:26:54 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJJQrm5016016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Dec 2013 14:26:53 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBJJQoIl030415; Thu, 19 Dec 2013 14:26:51 -0500 Message-ID: <52B34879.4020905@redhat.com> Date: Thu, 19 Dec 2013 19:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v9 21/29] record-btrace: provide xfer_partial target method References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-22-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1387471499-29444-22-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00800.txt.bz2 On 12/19/2013 04:44 PM, Markus Metzger wrote: Also, > + /* Filter out requests that don't make sense during replay. */ > + if (!record_btrace_allow_memory_access && record_btrace_is_replaying ()) > + { > + switch (object) > + { > + case TARGET_OBJECT_MEMORY: > + case TARGET_OBJECT_RAW_MEMORY: > + case TARGET_OBJECT_STACK_MEMORY: > + { I don't think you answered my comment about this in the previous series. I think you can't ever see TARGET_OBJECT_RAW_MEMORY or TARGET_OBJECT_STACK_MEMORY here. -- Pedro Alves