From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25489 invoked by alias); 19 Dec 2013 20:10:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25478 invoked by uid 89); 19 Dec 2013 20:10:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2013 20:10:21 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJKAHdP028550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Dec 2013 15:10:17 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBJKA7Kn011632; Thu, 19 Dec 2013 15:10:07 -0500 Message-ID: <52B3529E.70407@redhat.com> Date: Thu, 19 Dec 2013 20:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Metzger CC: jan.kratochvil@redhat.com, palves@redhat.com, gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [PATCH v9 29/29] record-btrace: add (reverse-)stepping support References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-30-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1387471499-29444-30-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00803.txt.bz2 On 12/19/2013 04:44 PM, Markus Metzger wrote: > + if (non_stop) > + error (_("Record btrace can't debug inferior in non-stop mode " > + "(non-stop).")); What's the intent of saying non-stop twice, in: "in non-stop mode (non-stop)" ? > + /* Stop all other threads. */ > + if (!non_stop) > + ALL_THREADS (other) > + other->btrace.flags &= ~BTHR_MOVE; (I know it doesn't work currently), but in non-stop, the event thread should also get its BTHR_MOVE flag cleared. I didn't spot where that was being done. > + /* GDB seems to need this. Without, a stale PC seems to be used resulting in > + the current location to be displayed incorrectly. */ > + registers_changed_ptid (tp->ptid); This really shouldn't be necessary, given target_resume does it for you. If you still needed, you're papering over some problem. -- Pedro Alves