From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10604 invoked by alias); 20 Dec 2013 15:36:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10594 invoked by uid 89); 20 Dec 2013 15:36:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 15:36:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBKFarbq011894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Dec 2013 10:36:53 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBKFapJf002404; Fri, 20 Dec 2013 10:36:52 -0500 Message-ID: <52B46412.8040901@redhat.com> Date: Fri, 20 Dec 2013 15:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Metzger, Markus T" CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" Subject: Re: [PATCH v9 21/29] record-btrace: provide xfer_partial target method References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-22-git-send-email-markus.t.metzger@intel.com> <52B34879.4020905@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00839.txt.bz2 On 12/20/2013 01:30 PM, Metzger, Markus T wrote: >> -----Original Message----- >> From: Pedro Alves [mailto:palves@redhat.com] >> Sent: Thursday, December 19, 2013 8:27 PM >> To: Metzger, Markus T >> Cc: jan.kratochvil@redhat.com; gdb-patches@sourceware.org >> Subject: Re: [PATCH v9 21/29] record-btrace: provide xfer_partial target >> method >> >> On 12/19/2013 04:44 PM, Markus Metzger wrote: >> >> Also, >> >>> + /* Filter out requests that don't make sense during replay. */ >>> + if (!record_btrace_allow_memory_access && >> record_btrace_is_replaying ()) >>> + { >>> + switch (object) >>> + { >>> + case TARGET_OBJECT_MEMORY: >>> + case TARGET_OBJECT_RAW_MEMORY: >>> + case TARGET_OBJECT_STACK_MEMORY: >>> + { >> >> I don't think you answered my comment about this in the previous >> series. I think you can't ever see TARGET_OBJECT_RAW_MEMORY or >> TARGET_OBJECT_STACK_MEMORY here. > > If we ever end up seeing them, they will simply be forwarded to the > target beneath without check. I think it's safer to leave them in. > If you'd rather have them removed, I can do that, as well. Please remove them. (Note how you'd already be missing TARGET_OBJECT_CODE_MEMORY.) If targets ever saw those, we'd need to update _all_ target's xfer_partial implementations. I see a reference to TARGET_OBJECT_RAW_MEMORY somehow ended up in record-full.c. We should remove that. As long as targets shouldn't see those, random references around the codebase just add to confusion (the reader needs to wonder why are those only handled in some targets, for no good reason). -- Pedro Alves