From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10129 invoked by alias); 20 Dec 2013 17:23:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10120 invoked by uid 89); 20 Dec 2013 17:23:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 17:23:39 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBKHNbeJ017163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Dec 2013 12:23:37 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBKHNYqD028755; Fri, 20 Dec 2013 12:23:35 -0500 Message-ID: <52B47D16.2020506@redhat.com> Date: Fri, 20 Dec 2013 17:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: Pedro Alves , Markus Metzger , jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v9 14/29] target: add ops parameter to to_prepare_to_store method References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-15-git-send-email-markus.t.metzger@intel.com> <52B33B4E.8070409@redhat.com> <87ioukk0io.fsf@fleche.redhat.com> In-Reply-To: <87ioukk0io.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-12/txt/msg00847.txt.bz2 On 12/19/2013 09:13 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> There are more sites that need updating. E.g., go32-nat.c, > Pedro> nto-procfs.c, windows-nat.c, possibly others. Try grepping > Pedro> for to_prepare_to_store. > [...] > Pedro> There should be a noprocess() call after the loop here. > > You can try this. I don't know whether it is complete but it's > certainly more complete. FAOD, it looks fine to me. Thanks, -- Pedro Alves