From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108644-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16475 invoked by alias); 20 Dec 2013 17:29:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16466 invoked by uid 89); 20 Dec 2013 17:29:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 17:29:27 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBKHTNDa028167	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 20 Dec 2013 12:29:23 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBKHTLHw032234;	Fri, 20 Dec 2013 12:29:22 -0500
Message-ID: <52B47E71.9080803@redhat.com>
Date: Fri, 20 Dec 2013 17:29:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Michael Sturm <michael.sturm@intel.com>
CC: eliz@gnu.org, mark.kettenis@xs4all.nl, walfred.tedeschi@intel.com,        gdb-patches@sourceware.org
Subject: Re: [PATCH v1 1/3] Add AVX512 registers support to GDB.
References: <1387533175-4039-1-git-send-email-michael.sturm@intel.com> <1387533175-4039-2-git-send-email-michael.sturm@intel.com>
In-Reply-To: <1387533175-4039-2-git-send-email-michael.sturm@intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-12/txt/msg00848.txt.bz2

Hi there,

I skimmed this (not a real review), and noticed:

> +send_gdb "print have_avx512 ()\r"
> +gdb_expect {

Please use gdb_test_multiple instead of send_gdb/gdb_expect.

> +    -re ".. = 1\r\n$gdb_prompt " {
> +        pass "check whether processor supports AVX512"
> +    }
> +    -re ".. = 0\r\n$gdb_prompt " {

Should be a pass too:

        pass "check whether processor supports AVX512"

As the test did its job.


> +    }
> +    -re ".*$gdb_prompt $" {
> +        fail "check whether processor supports AVX512"
> +    }
> +    timeout {
> +        fail "check whether processor supports AVX512 (timeout)"
> +    }

These last two won't be necessary then.

> +}
> +

This:


> +        verbose "processor does not support AVX512; skipping AVX512 tests"
> +        return

should probably instead be:

  unsupported "processor does not support AVX512; skipping AVX512 tests"

...

> +}
> \ No newline at end of file

Please add one.

-- 
Pedro Alves