From: Yufeng Zhang <Yufeng.Zhang@arm.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
Date: Mon, 23 Dec 2013 17:48:00 -0000 [thread overview]
Message-ID: <52B8773B.206@arm.com> (raw)
In-Reply-To: <m3ioufjxk2.fsf@redhat.com>
On 12/23/13 17:18, Sergio Durigan Junior wrote:
> On Monday, December 23 2013, Yufeng Zhang wrote:
>
>> Hi Sergio,
>
> Hey Yufeng,
>
>> Thanks for the updated patch. It looks OK to me and the only comment
>> I have is about the '$' character. In A64, only '#' can be the
>> optional prefix for immediate. I didn't see '$' checked in your
>> original patch; is there a particular reason that you added support
>> for '$' in this patch?
>
> Thanks a lot. You are right, only '#' is an optional prefix in
> AArch64. Here's an updated patch.
Thank you for your prompt action. It looks good to me. Please ask Tom
(or other global maintainer) for an approval if you need to get it in today.
Thanks,
Yufeng
next prev parent reply other threads:[~2013-12-23 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 22:20 Sergio Durigan Junior
2013-12-20 3:08 ` Sergio Durigan Junior
2013-12-23 16:52 ` Yufeng Zhang
2013-12-23 17:18 ` Sergio Durigan Junior
2013-12-23 17:48 ` Yufeng Zhang [this message]
2013-12-28 3:35 ` Joel Brobecker
2013-12-28 16:22 ` Sergio Durigan Junior
2013-12-28 23:36 ` Sergio Durigan Junior
2013-12-30 2:57 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B8773B.206@arm.com \
--to=yufeng.zhang@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).