From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8222 invoked by alias); 6 Jan 2014 19:52:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8208 invoked by uid 89); 6 Jan 2014 19:52:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2014 19:52:08 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s06Jq2R1023459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Jan 2014 14:52:03 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s06Jq1Te011575; Mon, 6 Jan 2014 14:52:01 -0500 Message-ID: <52CB0960.3000101@redhat.com> Date: Mon, 06 Jan 2014 19:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Omair Javaid CC: gdb-patches@sourceware.org, patches@linaro.org Subject: Re: [PATCH v2 4/7] Adds support for recording system call instructions References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00089.txt.bz2 On 01/03/2014 07:15 PM, Omair Javaid wrote: > + > + ret = record_linux_system_call (syscall_gdb, regcache, > + &arm_linux_record_tdep); This new call must mean this patch breaks the build until patch 6 is applied: 2014-01-03 Omair Javaid * configure.tgt: Add linux-record.o to gdb_target_obs. as record_linux_system_call is defined in linux-record.c. Please split that hunk from patch 6, and merge it into this one instead. The series (and therefore the resulting gdb history) should build and remain functional at each incremental step, to avoid bisecting problems. > +/* ARM process record-replay constructs; syscall, signal etc. */ Should be ':' instead of ';'. > + > +struct linux_record_tdep arm_linux_record_tdep; Other than that, the patch looks fine to me. -- Pedro Alves