From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3549 invoked by alias); 8 Jan 2014 12:34:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3532 invoked by uid 89); 8 Jan 2014 12:34:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Jan 2014 12:34:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s08CYCN1024844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Jan 2014 07:34:12 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s08CYBIB018943; Wed, 8 Jan 2014 07:34:11 -0500 Message-ID: <52CD45C2.8050507@redhat.com> Date: Wed, 08 Jan 2014 12:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Change to_xfer_partial 'len' type to ULONGEST. References: <1389166060-434-1-git-send-email-yao@codesourcery.com> <1389166060-434-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1389166060-434-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00200.txt.bz2 On 01/08/2014 07:27 AM, Yao Qi wrote: > @@ -178,7 +178,10 @@ ld_so_xfer_auxv (gdb_byte *readbuf, > } > > data_address += block; > - len -= block; > + if (len < block) > + len = 0; > + else > + len -= block; Is this a bug fix (if so, it should go is separately)? But, AFAICS, we have: if (block > len) block = len; above, so it shouldn't be necessary. > darwin_read_write_inferior (task_t task, CORE_ADDR addr, > gdb_byte *rdaddr, const gdb_byte *wraddr, > - int length) > + ULONGEST length) > { ... > @@ -1772,7 +1772,7 @@ darwin_read_write_inferior (task_t task, CORE_ADDR addr, > mach_vm_address_t region_address; > mach_vm_size_t region_length; > > - inferior_debug (8, _("darwin_read_write_inferior(task=0x%x, %s, len=%d)\n"), > + inferior_debug (8, _("darwin_read_write_inferior(task=0x%x, %s, len=%u)\n"), > task, core_addr_to_string (addr), length); Should be %s/pulongest. Otherwise looks good to me. -- Pedro Alves