From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1019 invoked by alias); 8 Jan 2014 13:30:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 992 invoked by uid 89); 8 Jan 2014 13:30:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Jan 2014 13:30:56 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s08DUtla025419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 Jan 2014 08:30:55 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s08DUre7012178; Wed, 8 Jan 2014 08:30:53 -0500 Message-ID: <52CD530D.6050903@redhat.com> Date: Wed, 08 Jan 2014 13:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] move the entry point info into the per-bfd object References: <1389040247-2620-1-git-send-email-tromey@redhat.com> <1389040247-2620-4-git-send-email-tromey@redhat.com> In-Reply-To: <1389040247-2620-4-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00206.txt.bz2 Looks good to me. > @@ -875,8 +879,8 @@ init_entry_point_info (struct objfile *objfile) > { > /* Executable file -- record its entry point so we'll recognize > the startup file because it contains the entry point. */ > - objfile->ei.entry_point = bfd_get_start_address (objfile->obfd); > - objfile->ei.entry_point_p = 1; > + objfile->per_bfd->ei.entry_point = bfd_get_start_address (objfile->obfd); > + objfile->per_bfd->ei.entry_point_p = 1; I think this has reached sufficient levels of indirection that if I were writing this, I'd do: static void init_entry_point_info (struct objfile *objfile) { + struct entry_info *ei = &objfile->per_bfd->ei; and then use ei-> throughout the function instead, like: if (ei->initialized) return; ei->initialized = 1; ... ei->entry_point = bfd_get_start_address (objfile->obfd); ei->entry_point_p = 1; ... etc. Just a suggestion. -- Pedro Alves