From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-109008-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23620 invoked by alias); 8 Jan 2014 15:31:59 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23586 invoked by uid 89); 8 Jan 2014 15:31:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL,BAYES_00,GARBLED_BODY autolearn=no version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Jan 2014 15:31:58 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1W0v6o-0007WG-VK from Yao_Qi@mentor.com ; Wed, 08 Jan 2014 07:31:54 -0800
Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Wed, 8 Jan 2014 07:31:54 -0800
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Wed, 8 Jan 2014 07:31:53 -0800
Message-ID: <52CD6F05.5090604@codesourcery.com>
Date: Wed, 08 Jan 2014 15:31:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Pedro Alves <palves@redhat.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4] Change to_xfer_partial 'len' type to ULONGEST.
References: <1389166060-434-1-git-send-email-yao@codesourcery.com> <1389166060-434-3-git-send-email-yao@codesourcery.com> <52CD45C2.8050507@redhat.com>
In-Reply-To: <52CD45C2.8050507@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
X-SW-Source: 2014-01/txt/msg00210.txt.bz2

On 01/08/2014 08:34 PM, Pedro Alves wrote:
> Is this a bug fix (if so, it should go is separately)?
> 

It is not a bug fix, just make sure 'len' can't be negative when we
change it unsigned type.

> But, AFAICS, we have:
> 
>       if (block > len)
> 	block = len;
> 
> above, so it shouldn't be necessary.

Right, this chunk of change is unnecessary.  I'll remove it from the
patch.

-- 
Yao (齐尧)