From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32667 invoked by alias); 9 Jan 2014 10:35:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32658 invoked by uid 89); 9 Jan 2014 10:35:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f52.google.com Received: from mail-wg0-f52.google.com (HELO mail-wg0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 09 Jan 2014 10:35:54 +0000 Received: by mail-wg0-f52.google.com with SMTP id b13so2327381wgh.7 for ; Thu, 09 Jan 2014 02:35:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=hjFGBdBgVwjNZtRMjFZqS2dhz3rev3tqVuNjxr/atU0=; b=id9K9Psp637y8W1H1RucTD5NIom6GjdxuxqIbDdFExoj5zf02t8C4AbzsICbgAI++4 +tK7uUQfLZi/q7ztnV5gWMJ2OQoqdKG+gl04X6HaSq4VoviTU0NvK8f1s8cymIPSsYJp EyrlgUQvUkpC27T7q6TjDKupCJE6kQPYdumJQ5BfjJUmFhgaR8YLN67UAAkicpPnZGV1 MTrbfzf48RTeBBesIh+C7bkYM7/Zw6Y3k+sermtNfXoVkm37ZHIGS6Wq3dRkzW3Hm+sd pqvIdp1h+Xi10giNBxs5FaPD4ClO6sGvBirHNovUIyc+TBnDGCuGMuluDWyINUew3+iD eOJA== X-Gm-Message-State: ALoCoQkvSA3F9Xkch7uwnnRmEHDagXRVclsGknCBCzSbioopkmFq5+FA6Uxv7LK7Bp/+iFag/mUs X-Received: by 10.194.234.65 with SMTP id uc1mr2102553wjc.39.1389263751668; Thu, 09 Jan 2014 02:35:51 -0800 (PST) Received: from [192.168.1.104] ([182.185.239.161]) by mx.google.com with ESMTPSA id pl7sm1151733wjc.16.2014.01.09.02.35.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 09 Jan 2014 02:35:50 -0800 (PST) Message-ID: <52CE7B81.1050908@linaro.org> Date: Thu, 09 Jan 2014 10:35:00 -0000 From: Omair Javaid User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org, patches@linaro.org Subject: Re: [PATCH v2 1/7] Fix for memory record corruption due to 64bit addresses References: <1c17769566e2e87f4c5be2df91aba4c0aff4806c.1388709773.git.omair.javaid@linaro.org> <52CB090F.1000404@redhat.com> In-Reply-To: <52CB090F.1000404@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00226.txt.bz2 On 01/07/2014 12:50 AM, Pedro Alves wrote: > On 01/03/2014 07:15 PM, Omair Javaid wrote: >> This patch changes record memory address type to unsigned 32bit integers. >> On targets where CORE_ADDR configures to become a unsigned 64bit value the >> arm process record code fails resulting in various testsuite failures. >> >> gdb: >> >> 2014-01-03 Omair Javaid >> >> * arm-tdep.c (struct arm_mem_r) : Change type to unit32_t. > > uint32_t. > > Other than that looks fine. > > Thanks, > Made the required change: gdb: 2014-01-03 Omair Javaid * arm-tdep.c (struct arm_mem_r) : Change type to uint32_t. --- gdb/arm-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 7c78a61..223a7db 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -10618,7 +10618,7 @@ vfp - VFP co-processor."), struct arm_mem_r { uint32_t len; /* Record length. */ - CORE_ADDR addr; /* Memory address. */ + uint32_t addr; /* Memory address. */ }; /* ARM instruction record contains opcode of current insn -- 1.7.9.5