public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Omair Javaid <omair.javaid@linaro.org>
Cc: gdb-patches@sourceware.org, patches@linaro.org
Subject: Re: [PATCH v2 4/7] Adds support for recording system call instructions
Date: Thu, 09 Jan 2014 17:14:00 -0000	[thread overview]
Message-ID: <52CED906.9020701@redhat.com> (raw)
In-Reply-To: <52CE7EB7.7000806@linaro.org>

On 01/09/2014 10:49 AM, Omair Javaid wrote:

> 2014-01-09  Omair Javaid  <omair.javaid@linaro.org>
> ...
> 	* configure.tgt: Add linux-record.o to gdb_target_obs.

Should mention which target got that:

	* configure.tgt (arm*-*-linux*): Add linux-record.o to
	gdb_target_obs.


> +  if (syscall <= gdb_sys_sched_getaffinity)
> +    return syscall;
> +  else if (syscall >= 243 && syscall <= 247 )
> +    return syscall + 2;
> +  else if (syscall >= 248 && syscall <= 253 )

Spurious spaces before ).

Otherwise OK, please push.

Thanks,
-- 
Pedro Alves

  reply	other threads:[~2014-01-09 17:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-03 19:16 [PATCH v2 0/7] ARM record/replay and reverse debugging improvements Omair Javaid
     [not found] ` <y@[87.69.4.28]>
     [not found]   ` <1385042577-5600-2-git-send-email-y@[87.69.4.28]>
2013-11-21 17:42     ` [PATCH 1/1] Documentation for MPX Eli Zaretskii
2014-01-03 19:16 ` [PATCH v2 7/7] Adds a NEWS entry for arm record/replay improvements Omair Javaid
2014-01-03 20:25   ` Eli Zaretskii
2014-01-09 11:25   ` Pedro Alves
2014-01-03 19:16 ` [PATCH v2 5/7] Adds support for thumb32 instructions recording Omair Javaid
2014-01-06 19:52   ` Pedro Alves
2014-01-09 10:34     ` Omair Javaid
2014-01-09 11:23       ` Pedro Alves
2014-01-09 11:34         ` Omair Javaid
2014-01-15 17:27           ` Will Newton
2014-01-15 17:49             ` Tom Tromey
2014-01-03 19:16 ` [PATCH v2 4/7] Adds support for recording system call instructions Omair Javaid
2014-01-06 19:52   ` Pedro Alves
2014-01-09 10:49     ` Omair Javaid
2014-01-09 17:14       ` Pedro Alves [this message]
2014-01-03 19:16 ` [PATCH v2 6/7] Updates configure.tgt and enables gdb.reverse testsuite Omair Javaid
2014-01-05 14:29   ` Yao Qi
2014-01-09 11:00     ` Omair Javaid
2014-01-09 11:25       ` Pedro Alves
2014-01-03 19:16 ` [PATCH v2 1/7] Fix for memory record corruption due to 64bit addresses Omair Javaid
2014-01-06 19:50   ` Pedro Alves
2014-01-09 10:35     ` Omair Javaid
2014-01-09 11:23       ` Pedro Alves
2014-01-03 19:16 ` [PATCH v2 2/7] Fix for bugs in push and ldm instructions decoding Omair Javaid
2014-01-06 19:50   ` Pedro Alves
2014-01-03 19:16 ` [PATCH v2 3/7] Fix for bug in pop instruction decoding Omair Javaid
2014-01-06 19:51   ` Pedro Alves
2014-01-06 19:54 ` [PATCH v2 0/7] ARM record/replay and reverse debugging improvements Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CED906.9020701@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=omair.javaid@linaro.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).