From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-109040-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31440 invoked by alias); 9 Jan 2014 17:14:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31349 invoked by uid 89); 9 Jan 2014 17:14:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2014 17:14:50 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s09HEl6t023147	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 9 Jan 2014 12:14:48 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s09HEk2J024669;	Thu, 9 Jan 2014 12:14:47 -0500
Message-ID: <52CED906.9020701@redhat.com>
Date: Thu, 09 Jan 2014 17:14:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Omair Javaid <omair.javaid@linaro.org>
CC: gdb-patches@sourceware.org, patches@linaro.org
Subject: Re: [PATCH v2 4/7] Adds support for recording system call instructions
References: <y> <cover.1388709773.git.omair.javaid@linaro.org> <a075cf819247b830e177a679b9fee17578fec22b.1388709773.git.omair.javaid@linaro.org> <52CB0960.3000101@redhat.com> <52CE7EB7.7000806@linaro.org>
In-Reply-To: <52CE7EB7.7000806@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-01/txt/msg00242.txt.bz2

On 01/09/2014 10:49 AM, Omair Javaid wrote:

> 2014-01-09  Omair Javaid  <omair.javaid@linaro.org>
> ...
> 	* configure.tgt: Add linux-record.o to gdb_target_obs.

Should mention which target got that:

	* configure.tgt (arm*-*-linux*): Add linux-record.o to
	gdb_target_obs.


> +  if (syscall <= gdb_sys_sched_getaffinity)
> +    return syscall;
> +  else if (syscall >= 243 && syscall <= 247 )
> +    return syscall + 2;
> +  else if (syscall >= 248 && syscall <= 253 )

Spurious spaces before ).

Otherwise OK, please push.

Thanks,
-- 
Pedro Alves