From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21972 invoked by alias); 14 Jan 2014 09:01:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21962 invoked by uid 89); 14 Jan 2014 09:01:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 09:01:27 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 14 Jan 2014 01:01:24 -0800 X-ExtLoop1: 1 Received: from msturm-mobl2.ger.corp.intel.com (HELO [172.28.205.59]) ([172.28.205.59]) by fmsmga002.fm.intel.com with ESMTP; 14 Jan 2014 01:01:20 -0800 Message-ID: <52D4FCDF.4060204@intel.com> Date: Tue, 14 Jan 2014 09:01:00 -0000 From: "Sturm, Michael" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Pedro Alves CC: eliz@gnu.org, mark.kettenis@xs4all.nl, walfred.tedeschi@intel.com, gdb-patches@sourceware.org Subject: Re: [PATCH v1 1/3] Add AVX512 registers support to GDB. References: <1387533175-4039-1-git-send-email-michael.sturm@intel.com> <1387533175-4039-2-git-send-email-michael.sturm@intel.com> <52B47E71.9080803@redhat.com> In-Reply-To: <52B47E71.9080803@redhat.com> Content-Type: text/plain; charset="iso-8859-1"; format="flowed" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-01/txt/msg00419.txt.bz2 Hi Pedro and Eli, Sorry for the delay in answering to you, we were out for the holidays.=20 Thanks a lot for your review, I'll address your suggestions in the next=20 revision of the patch. Hi Mark, did you have time to review the patches? Happy New Year to everybody! Thanks, Michael On 20/12/2013 18:29, Pedro Alves wrote: > Hi there, > > I skimmed this (not a real review), and noticed: > >> +send_gdb "print have_avx512 ()\r" >> +gdb_expect { > Please use gdb_test_multiple instead of send_gdb/gdb_expect. > >> + -re ".. =3D 1\r\n$gdb_prompt " { >> + pass "check whether processor supports AVX512" >> + } >> + -re ".. =3D 0\r\n$gdb_prompt " { > Should be a pass too: > > pass "check whether processor supports AVX512" > > As the test did its job. > > >> + } >> + -re ".*$gdb_prompt $" { >> + fail "check whether processor supports AVX512" >> + } >> + timeout { >> + fail "check whether processor supports AVX512 (timeout)" >> + } > These last two won't be necessary then. > >> +} >> + > This: > > >> + verbose "processor does not support AVX512; skipping AVX512 tes= ts" >> + return > should probably instead be: > > unsupported "processor does not support AVX512; skipping AVX512 tests" > > ... > >> +} >> \ No newline at end of file > Please add one. > Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052