From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29809 invoked by alias); 14 Jan 2014 10:52:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29798 invoked by uid 89); 14 Jan 2014 10:52:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 10:52:06 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0EAq4WQ013637 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 05:52:05 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0EAq3Vt012013; Tue, 14 Jan 2014 05:52:03 -0500 Message-ID: <52D516D2.9010200@redhat.com> Date: Tue, 14 Jan 2014 10:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC 04/32] add make-target-delegates References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-5-git-send-email-tromey@redhat.com> In-Reply-To: <1389640367-5571-5-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00422.txt.bz2 On 01/13/2014 07:12 PM, Tom Tromey wrote: > This patch adds a new script, call make-target-delegates, which > auto-generates some target delegation code based on annotations in > target.h. This adds the new delegation macros, the new generated > file, and adds the necessary calls to the new generated functions to > target.c. It doesn't, however, add any actual annotations to the > target methods, leaving these for separate patches. > > 2014-01-08 Tom Tromey > Maybe add the PR number to this one. > * target-delegates.c: New file. > * target.c: Include target-delegates.c. > (init_dummy_target): Call install_dummy_methods. > (complete_target_initialization): Call install_delegators. > * target.h (TARGET_DEFAULT_IGNORE, TARGET_DEFAULT_NORETURN) > (TARGET_DEFAULT_RETURN, TARGET_DEFAULT_FUNC): New defines. > * make-target-delegates: New file. Looks quite nice to me. > --- > gdb/ChangeLog | 10 ++ > gdb/make-target-delegates | 253 ++++++++++++++++++++++++++++++++++++++++++++++ > gdb/target-delegates.c | 14 +++ > gdb/target.c | 9 ++ > gdb/target.h | 24 +++++ > 5 files changed, 310 insertions(+) > create mode 100755 gdb/make-target-delegates > create mode 100644 gdb/target-delegates.c > > diff --git a/gdb/make-target-delegates b/gdb/make-target-delegates > new file mode 100755 > index 0000000..47f960c > --- /dev/null > +++ b/gdb/make-target-delegates > @@ -0,0 +1,253 @@ > +#!/usr/bin/perl > + > +# Copyright (C) 2013 Free Software Foundation, Inc. 2013-2014 -- Pedro Alves