From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5238 invoked by alias); 14 Jan 2014 12:10:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5226 invoked by uid 89); 14 Jan 2014 12:10:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 12:10:27 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0ECAQvT022281 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 07:10:26 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0ECAPZb019145; Tue, 14 Jan 2014 07:10:25 -0500 Message-ID: <52D52930.5060702@redhat.com> Date: Tue, 14 Jan 2014 12:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC 01/32] add "this" pointers to more target APIs References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-2-git-send-email-tromey@redhat.com> In-Reply-To: <1389640367-5571-2-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00424.txt.bz2 This looks about good to go to me. On 01/13/2014 07:12 PM, Tom Tromey wrote: > @@ -4761,8 +4759,8 @@ static void > linux_nat_close (void) > { > /* Unregister from the event loop. */ > - if (linux_nat_is_async_p ()) > - linux_nat_async (NULL, 0); > + if (linux_nat_is_async_p (linux_ops)) > + linux_nat_async (linux_ops, NULL, 0); I still think linux_ops is the wrong target to use here. While to_close doesn't have a self pointer, I'd suggest using NULL or adding a comment (or storing the multi-threaded target pointer in a global, though given the target really isn't used, that's probably overkill). > static int > -record_full_stopped_by_watchpoint (void) > +record_full_stopped_by_watchpoint (struct target_ops *ops) > { > if (RECORD_FULL_IS_REPLAY) > return record_full_hw_watchpoint; > else > - return record_full_beneath_to_stopped_by_watchpoint (); > + { > + struct target_ops *beneath = find_target_beneath (ops); > + > + return record_full_beneath_to_stopped_by_watchpoint (beneath); > + } (For the record, pedantically, this isn't strictly correct. It's not guaranteed the target just beneath is the one record_full_open found had a non-NULL t->to_stopped_by_watchpoint implementation. It'll end up fixed later in the series anyway though.) -- Pedro Alves