From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 06/32] convert to_supports_btrace
Date: Tue, 14 Jan 2014 12:37:00 -0000 [thread overview]
Message-ID: <52D52F98.1030403@redhat.com> (raw)
In-Reply-To: <1389640367-5571-7-git-send-email-tromey@redhat.com>
(Looks like the patch merge script lost the commit log of this one.)
Looks good to me though.
On 01/13/2014 07:12 PM, Tom Tromey wrote:
> ---
> gdb/common/linux-btrace.c | 4 ++--
> gdb/common/linux-btrace.h | 2 +-
> gdb/gdbserver/target.h | 7 ++++---
> gdb/remote.c | 2 +-
> gdb/target-delegates.c | 16 ++++++++++++++++
> gdb/target.c | 14 --------------
> gdb/target.h | 6 ++++--
> 7 files changed, 28 insertions(+), 23 deletions(-)
>
> diff --git a/gdb/common/linux-btrace.c b/gdb/common/linux-btrace.c
> index 7e20745..b3d1aaa 100644
> --- a/gdb/common/linux-btrace.c
> +++ b/gdb/common/linux-btrace.c
> @@ -400,7 +400,7 @@ cpu_supports_btrace (void)
> /* See linux-btrace.h. */
>
> int
> -linux_supports_btrace (void)
> +linux_supports_btrace (struct target_ops *ops)
> {
> static int cached;
>
> @@ -554,7 +554,7 @@ linux_read_btrace (struct btrace_target_info *tinfo,
> /* See linux-btrace.h. */
>
> int
> -linux_supports_btrace (void)
> +linux_supports_btrace (struct target_ops *ops)
> {
> return 0;
> }
> diff --git a/gdb/common/linux-btrace.h b/gdb/common/linux-btrace.h
> index d4e8402..16c4bb1 100644
> --- a/gdb/common/linux-btrace.h
> +++ b/gdb/common/linux-btrace.h
> @@ -62,7 +62,7 @@ struct btrace_target_info
> };
>
> /* Check whether branch tracing is supported. */
> -extern int linux_supports_btrace (void);
> +extern int linux_supports_btrace (struct target_ops *);
>
> /* Enable branch tracing for @ptid. */
> extern struct btrace_target_info *linux_enable_btrace (ptid_t ptid);
> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
> index c5e6fee..277838d 100644
> --- a/gdb/gdbserver/target.h
> +++ b/gdb/gdbserver/target.h
> @@ -350,7 +350,7 @@ struct target_ops
> int (*supports_agent) (void);
>
> /* Check whether the target supports branch tracing. */
> - int (*supports_btrace) (void);
> + int (*supports_btrace) (struct target_ops *);
>
> /* Enable branch tracing for @ptid and allocate a branch trace target
> information struct for reading and for disabling branch trace. */
> @@ -488,8 +488,9 @@ int kill_inferior (int);
> (the_target->supports_agent ? \
> (*the_target->supports_agent) () : 0)
>
> -#define target_supports_btrace() \
> - (the_target->supports_btrace ? (*the_target->supports_btrace) () : 0)
> +#define target_supports_btrace() \
> + (the_target->supports_btrace \
> + ? (*the_target->supports_btrace) (the_target) : 0)
>
> #define target_enable_btrace(ptid) \
> (*the_target->enable_btrace) (ptid)
> diff --git a/gdb/remote.c b/gdb/remote.c
> index a91e6aa..6f3fc91 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -11340,7 +11340,7 @@ struct btrace_target_info
> /* Check whether the target supports branch tracing. */
>
> static int
> -remote_supports_btrace (void)
> +remote_supports_btrace (struct target_ops *self)
> {
> if (remote_protocol_packets[PACKET_Qbtrace_off].support != PACKET_ENABLE)
> return 0;
> diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
> index 484945f..77f3113 100644
> --- a/gdb/target-delegates.c
> +++ b/gdb/target-delegates.c
> @@ -122,6 +122,19 @@ tdefault_xfer_partial (struct target_ops *self, enum target_object arg1, const
> return -1;
> }
>
> +static int
> +delegate_supports_btrace (struct target_ops *self)
> +{
> + self = self->beneath;
> + return self->to_supports_btrace (self);
> +}
> +
> +static int
> +tdefault_supports_btrace (struct target_ops *self)
> +{
> + return 0;
> +}
> +
> static void
> install_delegators (struct target_ops *ops)
> {
> @@ -147,6 +160,8 @@ install_delegators (struct target_ops *ops)
> ops->to_async = delegate_async;
> if (ops->to_xfer_partial == NULL)
> ops->to_xfer_partial = delegate_xfer_partial;
> + if (ops->to_supports_btrace == NULL)
> + ops->to_supports_btrace = delegate_supports_btrace;
> }
>
> static void
> @@ -163,4 +178,5 @@ install_dummy_methods (struct target_ops *ops)
> ops->to_is_async_p = find_default_is_async_p;
> ops->to_async = tdefault_async;
> ops->to_xfer_partial = tdefault_xfer_partial;
> + ops->to_supports_btrace = tdefault_supports_btrace;
> }
> diff --git a/gdb/target.c b/gdb/target.c
> index 0f614bf..6fc95fc 100644
> --- a/gdb/target.c
> +++ b/gdb/target.c
> @@ -4090,20 +4090,6 @@ target_ranged_break_num_registers (void)
>
> /* See target.h. */
>
> -int
> -target_supports_btrace (void)
> -{
> - struct target_ops *t;
> -
> - for (t = current_target.beneath; t != NULL; t = t->beneath)
> - if (t->to_supports_btrace != NULL)
> - return t->to_supports_btrace ();
> -
> - return 0;
> -}
> -
> -/* See target.h. */
> -
> struct btrace_target_info *
> target_enable_btrace (ptid_t ptid)
> {
> diff --git a/gdb/target.h b/gdb/target.h
> index 538bdf4..d1fa12f 100644
> --- a/gdb/target.h
> +++ b/gdb/target.h
> @@ -854,7 +854,8 @@ struct target_ops
> int (*to_can_use_agent) (void);
>
> /* Check whether the target supports branch tracing. */
> - int (*to_supports_btrace) (void);
> + int (*to_supports_btrace) (struct target_ops *)
> + TARGET_DEFAULT_RETURN (0);
>
> /* Enable branch tracing for PTID and allocate a branch trace target
> information struct for reading and for disabling branch trace. */
> @@ -1988,7 +1989,8 @@ extern void update_target_permissions (void);
> void target_ignore (void);
>
> /* See to_supports_btrace in struct target_ops. */
> -extern int target_supports_btrace (void);
> +#define target_supports_btrace() \
> + (current_target.to_supports_btrace (¤t_target))
>
> /* See to_enable_btrace in struct target_ops. */
> extern struct btrace_target_info *target_enable_btrace (ptid_t ptid);
>
--
Pedro Alves
next prev parent reply other threads:[~2014-01-14 12:37 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 19:12 [RFC 00/32] clean up target delegation Tom Tromey
2014-01-13 19:12 ` [RFC 01/32] add "this" pointers to more target APIs Tom Tromey
2014-01-14 12:10 ` Pedro Alves
2014-01-14 20:25 ` Tom Tromey
2014-01-13 19:12 ` [RFC 03/32] introduce async_callback_ftype Tom Tromey
2014-01-14 10:35 ` Pedro Alves
2014-01-14 10:50 ` Joel Brobecker
2014-01-14 15:06 ` Tom Tromey
2014-01-14 17:19 ` Joel Brobecker
2014-01-14 17:27 ` Tom Tromey
2014-01-14 18:30 ` Pedro Alves
2014-01-14 19:45 ` Tom Tromey
2014-01-15 15:25 ` Tom Tromey
2014-01-13 19:12 ` [RFC 02/32] introduce and use find_target_at Tom Tromey
2014-01-14 11:48 ` [PATCH] Fix "is a record target open" checks Pedro Alves
2014-01-14 15:30 ` Tom Tromey
2014-01-14 18:27 ` Pedro Alves
2014-01-15 16:22 ` Tom Tromey
2014-01-13 19:13 ` [RFC 11/32] Add target_ops argument to to_insert_vfork_catchpoint Tom Tromey
2014-01-14 12:52 ` Pedro Alves
2014-01-13 19:13 ` [RFC 09/32] Add target_ops argument to to_close Tom Tromey
2014-01-14 12:48 ` Pedro Alves
2014-01-13 19:13 ` [RFC 24/32] convert to_disable_tracepoint Tom Tromey
2014-01-14 18:49 ` Pedro Alves
2014-01-13 19:13 ` [RFC 12/32] Add target_ops argument to to_thread_name Tom Tromey
2014-01-14 13:03 ` Pedro Alves
2014-01-15 16:45 ` Tom Tromey
2014-01-16 17:50 ` Pedro Alves
2014-01-13 19:13 ` [RFC 19/32] convert to_detach Tom Tromey
2014-01-14 13:32 ` Pedro Alves
2014-01-13 19:13 ` [RFC 27/32] convert to_insert_mask_watchpoint Tom Tromey
2014-01-14 19:15 ` Pedro Alves
2014-01-14 19:23 ` Tom Tromey
2014-01-13 19:13 ` [RFC 10/32] Add target_ops argument to to_terminal_init Tom Tromey
2014-01-14 12:51 ` Pedro Alves
2014-01-13 19:13 ` [RFC 04/32] add make-target-delegates Tom Tromey
2014-01-14 10:52 ` Pedro Alves
2014-01-14 14:46 ` Tom Tromey
2014-01-13 19:13 ` [RFC 32/32] minor cleanups to update_current_target Tom Tromey
2014-01-14 20:10 ` Pedro Alves
2014-01-13 19:13 ` [RFC 26/32] convert to_static_tracepoint_markers_by_strid Tom Tromey
2014-01-14 18:57 ` Pedro Alves
2014-01-13 19:13 ` [RFC 31/32] change delegation for to_read_description Tom Tromey
2014-01-14 20:07 ` Pedro Alves
2014-01-14 20:22 ` Tom Tromey
2014-01-13 19:13 ` [RFC 08/32] remove extended_remote_create_inferior_1 Tom Tromey
2014-01-14 12:41 ` Pedro Alves
2014-01-16 19:20 ` Tom Tromey
2014-01-13 19:13 ` [RFC 25/32] convert to_upload_trace_state_variables Tom Tromey
2014-01-14 19:38 ` Pedro Alves
2014-01-13 19:23 ` [RFC 17/32] Add target_ops argument to to_static_tracepoint_markers_by_strid Tom Tromey
2014-01-14 13:25 ` Pedro Alves
2014-01-13 19:23 ` [RFC 20/32] convert to_remove_watchpoint Tom Tromey
2014-01-14 18:39 ` Pedro Alves
2014-01-14 18:55 ` Tom Tromey
2014-01-14 19:07 ` Tom Tromey
2014-01-14 20:38 ` Pedro Alves
2014-01-14 21:47 ` Tom Tromey
2014-01-13 19:23 ` [RFC 13/32] Add target_ops argument to to_get_ada_task_ptid Tom Tromey
2014-01-14 13:21 ` Pedro Alves
2014-01-13 19:23 ` [RFC 07/32] introduce remote_load Tom Tromey
2014-01-14 12:39 ` Pedro Alves
2014-01-13 19:24 ` [RFC 06/32] convert to_supports_btrace Tom Tromey
2014-01-14 12:37 ` Pedro Alves [this message]
2014-01-15 16:55 ` Tom Tromey
2014-01-13 19:24 ` [RFC 16/32] Add target_ops argument to to_upload_trace_state_variables Tom Tromey
2014-01-14 13:24 ` Pedro Alves
2014-01-13 19:24 ` [RFC 30/32] convert to_search_memory Tom Tromey
2014-01-14 19:45 ` Pedro Alves
2014-01-14 20:20 ` Tom Tromey
2014-01-13 19:37 ` [RFC 21/32] convert to_load Tom Tromey
2014-01-14 18:41 ` Pedro Alves
2014-01-13 19:38 ` [RFC 28/32] convert to_get_section_table Tom Tromey
2014-01-14 19:23 ` Pedro Alves
2014-01-14 19:29 ` Tom Tromey
2014-01-14 19:30 ` Pedro Alves
2014-01-15 16:43 ` Tom Tromey
2014-01-16 17:51 ` Pedro Alves
2014-01-13 19:38 ` [RFC 18/32] Add target_ops argument to to_save_record Tom Tromey
2014-01-14 13:26 ` Pedro Alves
2014-01-13 19:38 ` [RFC 23/32] convert to_thread_architecture Tom Tromey
2014-01-14 18:46 ` Pedro Alves
2014-01-13 19:38 ` [RFC 05/32] add target method delegation Tom Tromey
2014-01-14 12:32 ` Pedro Alves
2014-01-20 22:00 ` Tom Tromey
2014-01-13 19:38 ` [RFC 22/32] convert to_extra_thread_info Tom Tromey
2014-01-14 18:43 ` Pedro Alves
2014-01-13 19:40 ` [RFC 29/32] convert to_insn_history Tom Tromey
2014-01-14 19:29 ` Pedro Alves
2014-01-13 19:57 ` [RFC 15/32] Add target_ops argument to to_disable_tracepoint Tom Tromey
2014-01-14 13:23 ` Pedro Alves
2014-01-13 19:57 ` [RFC 14/32] Add target_ops argument to to_fileio_pwrite Tom Tromey
2014-01-14 13:22 ` Pedro Alves
2014-01-14 20:31 ` go32 fix Pedro Alves
2014-01-14 21:58 ` Tom Tromey
2014-01-15 12:55 ` [RFC 00/32] clean up target delegation Pedro Alves
2014-01-15 16:11 ` Tom Tromey
2014-01-15 20:05 ` Tom Tromey
2014-01-16 17:33 ` Pedro Alves
2014-01-16 19:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D52F98.1030403@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).