From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1131 invoked by alias); 14 Jan 2014 13:03:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1121 invoked by uid 89); 14 Jan 2014 13:03:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2014 13:03:24 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0ED3Mm8024942 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Jan 2014 08:03:23 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0ED3LcL006256; Tue, 14 Jan 2014 08:03:22 -0500 Message-ID: <52D53599.4040503@redhat.com> Date: Tue, 14 Jan 2014 13:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFC 12/32] Add target_ops argument to to_thread_name References: <1389640367-5571-1-git-send-email-tromey@redhat.com> <1389640367-5571-13-git-send-email-tromey@redhat.com> In-Reply-To: <1389640367-5571-13-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00432.txt.bz2 Looks fine to me. The patch is fine with me as is, but I'll note that I don't think there's any need for exec_set_find_memory_regions nowadays. Seems to me that exec_ops.to_find_memory_regions could always be set to objfile_find_memory_regions unconditionally. -- Pedro Alves