From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] relocate the entry point addess when used
Date: Wed, 15 Jan 2014 11:42:00 -0000 [thread overview]
Message-ID: <52D67425.9050904@redhat.com> (raw)
In-Reply-To: <8738kr1ug8.fsf@fleche.redhat.com>
On 01/13/2014 08:46 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Tom> I think the existing code here is wrong. It computes the entry point
> Tom> address directly from the BFD, not applying any runtime offsets.
> Tom> However, then objfile_relocate1 passes this address to find_pc_section
> Tom> -- which does use the offsets . So, it seems to me that the current
> Tom> code can only find the correct address by luck.
>
> Pedro> It's twisted, but I don't think it's luck. You can convince yourself
> Pedro> it works by debugging a PIE, and trying a backtrace past main
> Pedro> ("set backtrace past-main" will then trigger the code to stop the
> Pedro> backtrace at the entry point), or doing "info files" (shows the entry).
>
> Well, what I don't understand is that most addresses in dwarf2read.c are
> offset:
>
> baseaddr = ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
>
> ... however this is not done for the entry point, which comes directly
> from the BFD:
>
> objfile->per_bfd->ei.entry_point = bfd_get_start_address (objfile->obfd);
>
> I suppose there is some other invariant ensuring that the entry point is
> only computed when all the objfile offsets are zero. This part is not
> obvious to me.
I think it's just that the entry point is only really used for the main
executable, and if that is loaded at some relocation offset, we'll
always go through objfile_relocate (either PIE handling, or RSP
qOffsets handling for embedded systems) after reading in symbols,
while shared libraries are read in with the offsets already handy
upfront. Even though init_entry_point_info seemingly computes the
entry point for shared libraries, that's really still for the
main executable:
https://sourceware.org/ml/gdb-patches/2008-05/msg00112.html
and is probably indeed wrong for real shared libraries not
the main executable.
I do think your patch makes things much clearer and sturdier.
>
> [...]
> Pedro> This is assuming osect ends up NULL after iterating over all.
> Pedro> It's violating the abstraction of the macro. And, actually,
> Pedro> it's wrong, showing exactly why such assumptions are a bad idea:
>
> Sorry about that, I'll fix it up locally.
Thanks.
--
Pedro Alves
next prev parent reply other threads:[~2014-01-15 11:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 20:30 [PATCH 0/3] move entry point info to the per-BFD object Tom Tromey
2014-01-06 20:30 ` [PATCH 3/3] move the entry point info into the per-bfd object Tom Tromey
2014-01-08 13:30 ` Pedro Alves
2014-01-13 20:51 ` Tom Tromey
2014-01-06 20:30 ` [PATCH 1/3] change solib-frv to use entry_point_address_query Tom Tromey
2014-01-08 13:23 ` Pedro Alves
2014-01-06 20:30 ` [PATCH 2/3] relocate the entry point addess when used Tom Tromey
2014-01-08 13:22 ` Pedro Alves
2014-01-13 20:46 ` Tom Tromey
2014-01-15 11:42 ` Pedro Alves [this message]
2014-01-15 17:59 ` Tom Tromey
2014-01-15 18:02 ` Pedro Alves
2014-01-15 18:01 ` [PATCH 0/3] move entry point info to the per-BFD object Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D67425.9050904@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).