From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>,
gdb-patches@sourceware.org,
Ulrich Weigand <uweigand@de.ibm.com>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case
Date: Wed, 15 Jan 2014 21:33:00 -0000 [thread overview]
Message-ID: <52D6FEA9.6010605@linux.vnet.ibm.com> (raw)
In-Reply-To: <52D014B7.6040305@redhat.com>
On 01/10/2014 01:41 PM, Pedro Alves wrote:
> (Eh, I had meant to send that as reply to Jan, but somehow managed
> to botch it.)
>
> Here's what I pushed.
>
> --------
> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
> Date: Fri, 10 Jan 2014 15:37:36 +0000
> Subject: [PATCH] Since upstream gcc has recently increased the function
> alignment on S390, the dw2-dir-file-name test case fails in
> the first gdb_continue_to_breakpoint. Indeed, the
> breakpoint is now placed into the alignment gap *before*
> the actual function.
>
> This happens because the test case declares the respective "*_start"
> symbol as a "loose" label before the function definition, and the
> compiler inserts the alignment between that label and the function
> itself.
>
> The "*_start" symbols were only necessary because FUNC made the
> function static. The fix makes the functions extern instead, thus
> making the "*_start" labels unnecessary.
>
> testsuite/
> 2014-01-10 Andreas Arnez <arnez@linux.vnet.ibm.com>
> Pedro Alves <palves@redhat.com>
>
> * gdb.dwarf2/dw2-dir-file-name.c (FUNC): Remove "*_start" symbol.
> Make "name" extern.
> * gdb.dwarf2/dw2-dir-file-name.exp (out_cu, out_line): Replace
> references to ${name}_start by references to ${name}.
For some reason, the testcase is no longer successful on ppc64 (although it
still passes on ppc32): it hits the breakpoints, but no longer shows the
filename in none of the tests.
From gdb.log:
...
(gdb) break compdir_missing__ldir_missing__file_basename
Breakpoint 2 at 0x100006c4
(gdb) continue
Continuing.
Breakpoint 2, 0x00000000100006c4 in .compdir_missing.ldir_missing.file_basename ()
(gdb) FAIL: gdb.dwarf2/dw2-dir-file-name.exp: compdir_missing__ldir_missing__file_basename: continue to breakpoint: compdir_missing__ldir_missing__file_basename
...
=== gdb Summary ===
# of expected passes 97
# of unexpected failures 128
--
Edjunior
next prev parent reply other threads:[~2014-01-15 21:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 18:00 Andreas Arnez
2014-01-10 11:29 ` Pedro Alves
2014-01-10 14:30 ` Andreas Arnez
2014-01-10 14:53 ` Jan Kratochvil
2014-01-10 16:39 ` Pedro Alves
2014-01-15 21:33 ` Edjunior Barbosa Machado [this message]
2014-01-16 14:37 ` Pedro Alves
2014-01-17 17:58 ` Andreas Arnez
2014-01-17 18:09 ` Pedro Alves
2014-01-17 18:20 ` Pedro Alves
2014-01-20 19:47 ` Andreas Arnez
2014-01-22 13:15 ` Pedro Alves
2014-01-17 18:21 ` Edjunior Barbosa Machado
2014-01-22 16:13 ` Andreas Krebbel
2014-01-10 15:32 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D6FEA9.6010605@linux.vnet.ibm.com \
--to=emachado@linux.vnet.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=krebbel@linux.vnet.ibm.com \
--cc=palves@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).