From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31504 invoked by alias); 15 Jan 2014 21:33:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31494 invoked by uid 89); 15 Jan 2014 21:33:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e24smtp04.br.ibm.com Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 15 Jan 2014 21:33:38 +0000 Received: from /spool/local by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 15 Jan 2014 19:33:34 -0200 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp04.br.ibm.com (10.172.0.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 15 Jan 2014 19:33:31 -0200 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id CCF253520027 for ; Wed, 15 Jan 2014 16:33:29 -0500 (EST) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.8.31.93]) by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0FLX00P35979334 for ; Wed, 15 Jan 2014 19:33:01 -0200 Received: from d24av02.br.ibm.com (localhost [127.0.0.1]) by d24av02.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0FLXU7o012540 for ; Wed, 15 Jan 2014 19:33:30 -0200 Received: from [9.8.15.81] ([9.8.15.81]) by d24av02.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s0FLXTqd012495; Wed, 15 Jan 2014 19:33:29 -0200 Message-ID: <52D6FEA9.6010605@linux.vnet.ibm.com> Date: Wed, 15 Jan 2014 21:33:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Pedro Alves , Jan Kratochvil CC: Andreas Arnez , gdb-patches@sourceware.org, Ulrich Weigand , Andreas Krebbel Subject: Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case References: <87a9f65p73.fsf@br87z6lw.de.ibm.com> <52CFD97A.4040009@redhat.com> <87mwj352p5.fsf@br87z6lw.de.ibm.com> <20140110145327.GA23695@host2.jankratochvil.net> <52D014B7.6040305@redhat.com> In-Reply-To: <52D014B7.6040305@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14011521-8936-0000-0000-00000C6A532B X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00570.txt.bz2 On 01/10/2014 01:41 PM, Pedro Alves wrote: > (Eh, I had meant to send that as reply to Jan, but somehow managed > to botch it.) > > Here's what I pushed. > > -------- > From: Andreas Arnez > Date: Fri, 10 Jan 2014 15:37:36 +0000 > Subject: [PATCH] Since upstream gcc has recently increased the function > alignment on S390, the dw2-dir-file-name test case fails in > the first gdb_continue_to_breakpoint. Indeed, the > breakpoint is now placed into the alignment gap *before* > the actual function. > > This happens because the test case declares the respective "*_start" > symbol as a "loose" label before the function definition, and the > compiler inserts the alignment between that label and the function > itself. > > The "*_start" symbols were only necessary because FUNC made the > function static. The fix makes the functions extern instead, thus > making the "*_start" labels unnecessary. > > testsuite/ > 2014-01-10 Andreas Arnez > Pedro Alves > > * gdb.dwarf2/dw2-dir-file-name.c (FUNC): Remove "*_start" symbol. > Make "name" extern. > * gdb.dwarf2/dw2-dir-file-name.exp (out_cu, out_line): Replace > references to ${name}_start by references to ${name}. For some reason, the testcase is no longer successful on ppc64 (although it still passes on ppc32): it hits the breakpoints, but no longer shows the filename in none of the tests. >From gdb.log: ... (gdb) break compdir_missing__ldir_missing__file_basename Breakpoint 2 at 0x100006c4 (gdb) continue Continuing. Breakpoint 2, 0x00000000100006c4 in .compdir_missing.ldir_missing.file_basename () (gdb) FAIL: gdb.dwarf2/dw2-dir-file-name.exp: compdir_missing__ldir_missing__file_basename: continue to breakpoint: compdir_missing__ldir_missing__file_basename ... === gdb Summary === # of expected passes 97 # of unexpected failures 128 -- Edjunior