From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/6] gdbserver: Delimit debugging output for readability
Date: Thu, 16 Jan 2014 18:39:00 -0000 [thread overview]
Message-ID: <52D826DF.4000505@codesourcery.com> (raw)
In-Reply-To: <21205.55987.69477.892571@ruffy.mtv.corp.google.com>
On 01/15/2014 08:47 AM, Doug Evans wrote:
> While going through the reviews, I found myself wanting something more,
> namely timestamps (like "set debug timestamp on" in gdb).
>
Hi Doug,
Could you help me to understand how useful timestamps are for
measuring performance? or you use timestamps for other purposes?
> This patch adds a check for gettimeofday and doesn't fall back to using one
> in libiberty or gnulib, leaving that for another day.
gdbserver has used gnulib, which means we can use gettimeofday
unconditionally in gdbserver?
> diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
> index 1b0da6c..e7d3e4f 100644
> --- a/gdb/gdbserver/linux-aarch64-low.c
> +++ b/gdb/gdbserver/linux-aarch64-low.c
> @@ -323,7 +323,7 @@ aarch64_get_pc (struct regcache *regcache)
>
> collect_register_by_name (regcache, "pc", &pc);
> if (debug_threads)
> - fprintf (stderr, "stop pc is %08lx\n", pc);
> + debug_printf ("stop pc is %08lx\n", pc);
> return pc;
IWBN to move "if (debug_threads)" into debug_printf too.
> diff --git a/gdb/gdbserver/utils.c b/gdb/gdbserver/utils.c
> index eff4499..1ce5512 100644
> --- a/gdb/gdbserver/utils.c
> +++ b/gdb/gdbserver/utils.c
> @@ -17,6 +17,7 @@
> +
> +/* Increase or decrease the debug printf call nesting level.
> + FUNCTION_NAME is the name of the calling function, or NULL if unknown.
> + Call this when entering major routines that can trigger a lot of debug
> + output before it exits. It allows the reader to associate subsequent
> + debug output to the call that ultimately triggered it. */
> +
> +void
> +debug_level_incr (int incr, const char *function_name)
> +{
> + gdb_assert (incr == 1 || incr == -1);
> +
> + /* Increment(/decrement) the level by one before printing the function name,
> + to distinguish this as an entry(/exit) point.
> + Then increment(/decrement) it again so that debugging printfs within
> + the function are recognized as such. */
> + if (function_name != NULL)
> + {
> + debug_nesting_level += incr;
> + debug_printf ("%s %s\n",
> + incr > 0 ? ">>>>entering" : "<<<<exiting",
> + function_name);
> + }
> + debug_nesting_level += incr;
> +
> + /* Don't crash on mismatched enter/exit, but still inform the user. */
> + if (debug_nesting_level < 0)
> + {
> + debug_printf ("ERROR: mismatch in debug_level_enter/exit, level < 0\n");
> + debug_nesting_level = 0;
> + }
> +}
> +
utils.c is compiled to both gdbserver and ipa. IMO,
ipa code should be thread-safe, because it can be used by a
multi-threaded program.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-01-16 18:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 21:47 Doug Evans
2013-12-18 11:17 ` Pedro Alves
2014-01-15 0:47 ` Doug Evans
2014-01-16 17:22 ` Pedro Alves
2014-01-16 18:43 ` Doug Evans
2014-01-16 18:54 ` Pedro Alves
2014-01-16 23:28 ` [PATCH 0/3] Add debug_printf and timestamps to gdbserver Doug Evans
2014-01-16 23:31 ` [PATCH 1/3] gdbserver debug_printf+timestamps: FUNCTION_NAME Doug Evans
2014-01-17 12:46 ` Pedro Alves
2014-01-16 23:33 ` [PATCH 2/3] gdbserver debug_printf+timestamps: delim_string_to_char_ptr_vec_append Doug Evans
2014-01-16 23:37 ` [PATCH 3/3, doc RFA] gdbserver debug_printf+timestamps: main patch Doug Evans
2014-01-17 2:58 ` Doug Evans
2014-01-17 7:04 ` Eli Zaretskii
2014-01-17 12:46 ` Pedro Alves
2014-01-17 22:45 ` Doug Evans
2014-01-18 8:25 ` Eli Zaretskii
2014-01-20 16:14 ` Pedro Alves
2014-01-22 23:06 ` Doug Evans
2014-01-16 18:39 ` Yao Qi [this message]
2014-01-16 19:01 ` [PATCH 4/6] gdbserver: Delimit debugging output for readability Doug Evans
2014-01-17 2:32 ` Joel Brobecker
2014-01-17 2:40 ` Joel Brobecker
2014-01-17 12:46 ` Pedro Alves
2014-01-17 12:59 ` Yao Qi
2014-01-20 5:42 ` Tom Tromey
2014-01-20 19:51 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D826DF.4000505@codesourcery.com \
--to=yao@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).