From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17248 invoked by alias); 17 Jan 2014 13:07:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17239 invoked by uid 89); 17 Jan 2014 13:07:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2014 13:07:05 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0HD72fI006640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Jan 2014 08:07:02 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0HD6xgI030700; Fri, 17 Jan 2014 08:07:00 -0500 Message-ID: <52D92AF3.7030905@redhat.com> Date: Fri, 17 Jan 2014 13:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Baruch Siach CC: Maxim Grigoriev , gdb-patches@sourceware.org, Marc Gauthier , Dror Maydan Subject: Re: [PATCH] gdb: xtensa: fix build References: <52D80CCB.4040008@redhat.com> <20140116170135.GF4602@tarshish> <20140116202727.GH4602@tarshish> In-Reply-To: <20140116202727.GH4602@tarshish> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00675.txt.bz2 On 01/16/2014 08:27 PM, Baruch Siach wrote: > Hi Maxim, > > On Thu, Jan 16, 2014 at 12:11:41PM -0800, Maxim Grigoriev wrote: >> Hello Pedro and Baruch, >> >> I actually haven't been doing Xtensa GDB maintenance for quite some time >> now since I left Tensilica. > > Since xtensa-linux-nat.c used PTRACE_GETXTREGS since the beginning, and since > sys/ptrace.h (at least on uClibc) never defined this value, the question is > simply how did you build gdb at the time? > > I should note that Buildroot is carrying this patch for more than a year now. Alright. Indeed, the original submission left me wondering whether the "We" in "We need" might even be talking about a different libc than what the original port was done against (if not, weird that this didn't come up then), and if so, then I have to wonder whether just switching to asm/ptrace.h might be breaking the build against other libc (glibc?), and therefore we might need to include both. So mainly I'm just looking for a little more confirmation and more extended description for the commit log / archives. -- Pedro Alves