From: Pedro Alves <palves@redhat.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>,
gdb-patches@sourceware.org,
Ulrich Weigand <uweigand@de.ibm.com>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case
Date: Fri, 17 Jan 2014 18:09:00 -0000 [thread overview]
Message-ID: <52D971DA.90807@redhat.com> (raw)
In-Reply-To: <874n5232yj.fsf@br87z6lw.de.ibm.com>
On 01/17/2014 05:58 PM, Andreas Arnez wrote:
> On Thu, Jan 16 2014, Pedro Alves wrote:
>
>> On 01/15/2014 09:33 PM, Edjunior Barbosa Machado wrote:
>>>
>>
>>>> testsuite/
>>>> 2014-01-10 Andreas Arnez <arnez@linux.vnet.ibm.com>
>>>> Pedro Alves <palves@redhat.com>
>>>>
>>>> * gdb.dwarf2/dw2-dir-file-name.c (FUNC): Remove "*_start" symbol.
>>>> Make "name" extern.
>>>> * gdb.dwarf2/dw2-dir-file-name.exp (out_cu, out_line): Replace
>>>> references to ${name}_start by references to ${name}.
>>>
>>> For some reason, the testcase is no longer successful on ppc64 (although it
>>> still passes on ppc32): it hits the breakpoints, but no longer shows the
>>> filename in none of the tests.
>>>
>>> From gdb.log:
>>> ...
>>> (gdb) break compdir_missing__ldir_missing__file_basename
>>> Breakpoint 2 at 0x100006c4
>>> (gdb) continue
>>> Continuing.
>>>
>>> Breakpoint 2, 0x00000000100006c4 in .compdir_missing.ldir_missing.file_basename ()
>>
>> Bah, looks like the function's low_pc ends up pointing to the function
>> descriptor (because that's what the "name" symbol resolves to in the
>> debug info in the .S file)? Looks like we'll need some other solution.
>
> OK, how about this?
Nice and simple. I like it.
> ----
> Subject: [PATCH] Re-introduce '_start' labels and add alignment in dw2-dir-file-name test case.
>
> On ppc64-linux a function symbol does not point to code, but to the
> function descriptor. Thus the previous change for this test case
> broke it:
>
> https://sourceware.org/ml/gdb-patches/2014-01/msg00275.html
>
> This patch reverts to the original method, re-introducing '_start'
> symbols. In addition, it adds sufficient alignment before the label,
> such that the label never points into an alignment gap.
>
> testsuite/
> 2014-01-17 Andreas Arnez <arnez@linux.vnet.ibm.com>
>
> * gdb.dwarf2/dw2-dir-file-name.c (FUNC): Insert alignment and
> define "*_start" label. Make "name" static.
>
No empty line here please.
> * gdb.dwarf2/dw2-dir-file-name.exp: Replace references to
> ${name} by references to ${name}_start.
--
Pedro Alves
next prev parent reply other threads:[~2014-01-17 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 18:00 Andreas Arnez
2014-01-10 11:29 ` Pedro Alves
2014-01-10 14:30 ` Andreas Arnez
2014-01-10 14:53 ` Jan Kratochvil
2014-01-10 16:39 ` Pedro Alves
2014-01-15 21:33 ` Edjunior Barbosa Machado
2014-01-16 14:37 ` Pedro Alves
2014-01-17 17:58 ` Andreas Arnez
2014-01-17 18:09 ` Pedro Alves [this message]
2014-01-17 18:20 ` Pedro Alves
2014-01-20 19:47 ` Andreas Arnez
2014-01-22 13:15 ` Pedro Alves
2014-01-17 18:21 ` Edjunior Barbosa Machado
2014-01-22 16:13 ` Andreas Krebbel
2014-01-10 15:32 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D971DA.90807@redhat.com \
--to=palves@redhat.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=krebbel@linux.vnet.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).