From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20104 invoked by alias); 17 Jan 2014 18:09:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20095 invoked by uid 89); 17 Jan 2014 18:09:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2014 18:09:37 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0HI9W9G025089 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Jan 2014 13:09:32 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0HI9UN9013842; Fri, 17 Jan 2014 13:09:30 -0500 Message-ID: <52D971DA.90807@redhat.com> Date: Fri, 17 Jan 2014 18:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andreas Arnez CC: Edjunior Barbosa Machado , Jan Kratochvil , gdb-patches@sourceware.org, Ulrich Weigand , Andreas Krebbel Subject: Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case References: <87a9f65p73.fsf@br87z6lw.de.ibm.com> <52CFD97A.4040009@redhat.com> <87mwj352p5.fsf@br87z6lw.de.ibm.com> <20140110145327.GA23695@host2.jankratochvil.net> <52D014B7.6040305@redhat.com> <52D6FEA9.6010605@linux.vnet.ibm.com> <52D7EEA9.4030006@redhat.com> <874n5232yj.fsf@br87z6lw.de.ibm.com> In-Reply-To: <874n5232yj.fsf@br87z6lw.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-01/txt/msg00681.txt.bz2 On 01/17/2014 05:58 PM, Andreas Arnez wrote: > On Thu, Jan 16 2014, Pedro Alves wrote: > >> On 01/15/2014 09:33 PM, Edjunior Barbosa Machado wrote: >>> >> >>>> testsuite/ >>>> 2014-01-10 Andreas Arnez >>>> Pedro Alves >>>> >>>> * gdb.dwarf2/dw2-dir-file-name.c (FUNC): Remove "*_start" symbol. >>>> Make "name" extern. >>>> * gdb.dwarf2/dw2-dir-file-name.exp (out_cu, out_line): Replace >>>> references to ${name}_start by references to ${name}. >>> >>> For some reason, the testcase is no longer successful on ppc64 (although it >>> still passes on ppc32): it hits the breakpoints, but no longer shows the >>> filename in none of the tests. >>> >>> From gdb.log: >>> ... >>> (gdb) break compdir_missing__ldir_missing__file_basename >>> Breakpoint 2 at 0x100006c4 >>> (gdb) continue >>> Continuing. >>> >>> Breakpoint 2, 0x00000000100006c4 in .compdir_missing.ldir_missing.file_basename () >> >> Bah, looks like the function's low_pc ends up pointing to the function >> descriptor (because that's what the "name" symbol resolves to in the >> debug info in the .S file)? Looks like we'll need some other solution. > > OK, how about this? Nice and simple. I like it. > ---- > Subject: [PATCH] Re-introduce '_start' labels and add alignment in dw2-dir-file-name test case. > > On ppc64-linux a function symbol does not point to code, but to the > function descriptor. Thus the previous change for this test case > broke it: > > https://sourceware.org/ml/gdb-patches/2014-01/msg00275.html > > This patch reverts to the original method, re-introducing '_start' > symbols. In addition, it adds sufficient alignment before the label, > such that the label never points into an alignment gap. > > testsuite/ > 2014-01-17 Andreas Arnez > > * gdb.dwarf2/dw2-dir-file-name.c (FUNC): Insert alignment and > define "*_start" label. Make "name" static. > No empty line here please. > * gdb.dwarf2/dw2-dir-file-name.exp: Replace references to > ${name} by references to ${name}_start. -- Pedro Alves