From: Pedro Alves <alves.ped@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>,
Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>,
gdb-patches@sourceware.org, Ulrich Weigand <uweigand@de.ibm.com>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>,
Omair Javaid <omair.javaid@linaro.org>
Subject: Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case
Date: Fri, 17 Jan 2014 18:20:00 -0000 [thread overview]
Message-ID: <52D97460.1040206@gmail.com> (raw)
In-Reply-To: <52D971DA.90807@redhat.com>
BTW,
(adding Omair)
On 01/17/2014 05:58 PM, Andreas Arnez wrote:
> +/* Notes: (1) The '*_start' label below is needed because 'name' may
> + point to a function descriptor instead of to the actual code. (2)
> + The '.balign' should specify the highest possible function
> + alignment across all supported architectures, such that the label
> + never points into the alignment gap. */
> +
> #define FUNC(name) \
> - void \
> + asm (".balign 8"); \
> + asm (#name "_start: .globl " #name "_start\n"); \
> + static void \
> name (void) \
Not sure you were following the
"testsuite/gdb.dwarf2: Fix for dw2-ifort-parameter failure on ARM"
thread. Seems to me this exact same thing should be done to
dw2-ifort-parameter.c. I assume that test is currently failing
on ppc64 for the exact same reason, and that if it's not failing
on S390 with current gcc, it'll be by lucky alignment. I believe
this approach should fix Thumb there as well. Can you guys
coordinate on handling that test? Thanks.
--
Pedro Alves
next prev parent reply other threads:[~2014-01-17 18:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 18:00 Andreas Arnez
2014-01-10 11:29 ` Pedro Alves
2014-01-10 14:30 ` Andreas Arnez
2014-01-10 14:53 ` Jan Kratochvil
2014-01-10 16:39 ` Pedro Alves
2014-01-15 21:33 ` Edjunior Barbosa Machado
2014-01-16 14:37 ` Pedro Alves
2014-01-17 17:58 ` Andreas Arnez
2014-01-17 18:09 ` Pedro Alves
2014-01-17 18:20 ` Pedro Alves [this message]
2014-01-20 19:47 ` Andreas Arnez
2014-01-22 13:15 ` Pedro Alves
2014-01-17 18:21 ` Edjunior Barbosa Machado
2014-01-22 16:13 ` Andreas Krebbel
2014-01-10 15:32 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D97460.1040206@gmail.com \
--to=alves.ped@gmail.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=krebbel@linux.vnet.ibm.com \
--cc=omair.javaid@linaro.org \
--cc=palves@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).