From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 455 invoked by alias); 17 Jan 2014 18:20:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 428 invoked by uid 89); 17 Jan 2014 18:20:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f173.google.com Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 17 Jan 2014 18:20:21 +0000 Received: by mail-wi0-f173.google.com with SMTP id d13so1086116wiw.0 for ; Fri, 17 Jan 2014 10:20:19 -0800 (PST) X-Received: by 10.180.184.105 with SMTP id et9mr3878638wic.36.1389982818802; Fri, 17 Jan 2014 10:20:18 -0800 (PST) Received: from [192.168.0.105] (bl16-5-222.dsl.telepac.pt. [188.81.5.222]) by mx.google.com with ESMTPSA id a9sm4426445wiy.10.2014.01.17.10.20.17 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 17 Jan 2014 10:20:18 -0800 (PST) Message-ID: <52D97460.1040206@gmail.com> Date: Fri, 17 Jan 2014 18:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pedro Alves CC: Andreas Arnez , Edjunior Barbosa Machado , Jan Kratochvil , gdb-patches@sourceware.org, Ulrich Weigand , Andreas Krebbel , Omair Javaid Subject: Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case References: <87a9f65p73.fsf@br87z6lw.de.ibm.com> <52CFD97A.4040009@redhat.com> <87mwj352p5.fsf@br87z6lw.de.ibm.com> <20140110145327.GA23695@host2.jankratochvil.net> <52D014B7.6040305@redhat.com> <52D6FEA9.6010605@linux.vnet.ibm.com> <52D7EEA9.4030006@redhat.com> <874n5232yj.fsf@br87z6lw.de.ibm.com> <52D971DA.90807@redhat.com> In-Reply-To: <52D971DA.90807@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00682.txt.bz2 BTW, (adding Omair) On 01/17/2014 05:58 PM, Andreas Arnez wrote: > +/* Notes: (1) The '*_start' label below is needed because 'name' may > + point to a function descriptor instead of to the actual code. (2) > + The '.balign' should specify the highest possible function > + alignment across all supported architectures, such that the label > + never points into the alignment gap. */ > + > #define FUNC(name) \ > - void \ > + asm (".balign 8"); \ > + asm (#name "_start: .globl " #name "_start\n"); \ > + static void \ > name (void) \ Not sure you were following the "testsuite/gdb.dwarf2: Fix for dw2-ifort-parameter failure on ARM" thread. Seems to me this exact same thing should be done to dw2-ifort-parameter.c. I assume that test is currently failing on ppc64 for the exact same reason, and that if it's not failing on S390 with current gcc, it'll be by lucky alignment. I believe this approach should fix Thumb there as well. Can you guys coordinate on handling that test? Thanks. -- Pedro Alves