From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4185 invoked by alias); 17 Jan 2014 18:21:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4159 invoked by uid 89); 17 Jan 2014 18:21:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e24smtp03.br.ibm.com Received: from e24smtp03.br.ibm.com (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 17 Jan 2014 18:21:23 +0000 Received: from /spool/local by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 Jan 2014 16:21:18 -0200 Received: from d24dlp02.br.ibm.com (9.18.248.206) by e24smtp03.br.ibm.com (10.172.0.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 17 Jan 2014 16:21:17 -0200 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 7A9DD1DC005D for ; Fri, 17 Jan 2014 13:21:16 -0500 (EST) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.8.31.93]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0HILMDd4645048 for ; Fri, 17 Jan 2014 16:21:23 -0200 Received: from d24av02.br.ibm.com (localhost [127.0.0.1]) by d24av02.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0HILFf3029810 for ; Fri, 17 Jan 2014 16:21:15 -0200 Received: from [9.8.10.13] ([9.8.10.13]) by d24av02.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s0HILFeN029806; Fri, 17 Jan 2014 16:21:15 -0200 Message-ID: <52D9749A.5060002@linux.vnet.ibm.com> Date: Fri, 17 Jan 2014 18:21:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Andreas Arnez , Pedro Alves CC: Jan Kratochvil , gdb-patches@sourceware.org, Ulrich Weigand , Andreas Krebbel Subject: Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case References: <87a9f65p73.fsf@br87z6lw.de.ibm.com> <52CFD97A.4040009@redhat.com> <87mwj352p5.fsf@br87z6lw.de.ibm.com> <20140110145327.GA23695@host2.jankratochvil.net> <52D014B7.6040305@redhat.com> <52D6FEA9.6010605@linux.vnet.ibm.com> <52D7EEA9.4030006@redhat.com> <874n5232yj.fsf@br87z6lw.de.ibm.com> In-Reply-To: <874n5232yj.fsf@br87z6lw.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14011718-9254-0000-0000-00000EC471E9 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00683.txt.bz2 On 01/17/2014 03:58 PM, Andreas Arnez wrote: > OK, how about this? > > ---- > Subject: [PATCH] Re-introduce '_start' labels and add alignment in dw2-dir-file-name test case. > > On ppc64-linux a function symbol does not point to code, but to the > function descriptor. Thus the previous change for this test case > broke it: > > https://sourceware.org/ml/gdb-patches/2014-01/msg00275.html > > This patch reverts to the original method, re-introducing '_start' > symbols. In addition, it adds sufficient alignment before the label, > such that the label never points into an alignment gap. > > testsuite/ > 2014-01-17 Andreas Arnez > > * gdb.dwarf2/dw2-dir-file-name.c (FUNC): Insert alignment and > define "*_start" label. Make "name" static. > > * gdb.dwarf2/dw2-dir-file-name.exp: Replace references to > ${name} by references to ${name}_start. Great! This patch solves all the failures on ppc64. Thanks a lot, Andreas. -- Edjunior