From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5674 invoked by alias); 21 Jan 2014 20:44:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5664 invoked by uid 89); 21 Jan 2014 20:44:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Jan 2014 20:44:46 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0LKii1f014344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 21 Jan 2014 15:44:44 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0LKiitV016486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 21 Jan 2014 15:44:44 -0500 Message-ID: <52DEDC3B.60005@redhat.com> Date: Tue, 21 Jan 2014 20:44:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 05/11] Rename varobj_pretty_printed_p to varobj_is_dynamic_p References: <1385258996-26047-1-git-send-email-yao@codesourcery.com> <1385258996-26047-6-git-send-email-yao@codesourcery.com> In-Reply-To: <1385258996-26047-6-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00818.txt.bz2 On 11/23/2013 06:09 PM, Yao Qi wrote: > We think varobj with --available-children-only behaves like a dynamic > varobj, so dyanmic varobj is not pretty-printer specific. We rename > varobj_pretty_printed_p to varobj_is_dynamic_p, so that we can handle > available-children-only checking in varobj_is_dynamic_p in the next > patch. One little nit, otherwise, this looks good to me. Keith > > gdb: > > 2013-11-24 Yao Qi > > * varobj.c (varobj_pretty_printed_p): Rename to ... > (varobj_is_dynamic_p): ... this. New function. > * varobj.h (varobj_pretty_printed_p): Remove declaration. > (varobj_is_dynamic_p): Declare. > * mi/mi-cmd-var.c (print_varobj): Caller update. "Caller updated" or "Update caller" > (mi_print_value_p, varobj_update_one): Likewise. > --- > gdb/mi/mi-cmd-var.c | 6 +++--- > gdb/varobj.c | 4 +++- > gdb/varobj.h | 2 +- > 3 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/gdb/mi/mi-cmd-var.c b/gdb/mi/mi-cmd-var.c > index 84cdc15..2201630 100644 > --- a/gdb/mi/mi-cmd-var.c > +++ b/gdb/mi/mi-cmd-var.c > @@ -88,7 +88,7 @@ print_varobj (struct varobj *var, enum print_values print_values, > xfree (display_hint); > } > > - if (varobj_pretty_printed_p (var)) > + if (varobj_is_dynamic_p (var)) > ui_out_field_int (uiout, "dynamic", 1); > } > > @@ -352,7 +352,7 @@ mi_print_value_p (struct varobj *var, enum print_values print_values) > if (print_values == PRINT_ALL_VALUES) > return 1; > > - if (varobj_pretty_printed_p (var)) > + if (varobj_is_dynamic_p (var)) > return 1; > > type = varobj_get_gdb_type (var); > @@ -777,7 +777,7 @@ varobj_update_one (struct varobj *var, enum print_values print_values, > xfree (display_hint); > } > > - if (varobj_pretty_printed_p (r->varobj)) > + if (varobj_is_dynamic_p (r->varobj)) > ui_out_field_int (uiout, "dynamic", 1); > > varobj_get_child_range (r->varobj, &from, &to); > diff --git a/gdb/varobj.c b/gdb/varobj.c > index e362229..948f80c 100644 > --- a/gdb/varobj.c > +++ b/gdb/varobj.c > @@ -1066,8 +1066,10 @@ varobj_get_attributes (struct varobj *var) > return attributes; > } > > +/* Return true if VAR is a dynamic varobj. */ > + > int > -varobj_pretty_printed_p (struct varobj *var) > +varobj_is_dynamic_p (struct varobj *var) > { > return var->dynamic->pretty_printer != NULL; > } > diff --git a/gdb/varobj.h b/gdb/varobj.h > index 0f68311..60ace6f 100644 > --- a/gdb/varobj.h > +++ b/gdb/varobj.h > @@ -306,7 +306,7 @@ extern void varobj_enable_pretty_printing (void); > > extern int varobj_has_more (struct varobj *var, int to); > > -extern int varobj_pretty_printed_p (struct varobj *var); > +extern int varobj_is_dynamic_p (struct varobj *var); > > extern struct cleanup *varobj_ensure_python_env (struct varobj *var); > >