From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27290 invoked by alias); 22 Jan 2014 12:16:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27275 invoked by uid 89); 22 Jan 2014 12:16:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Jan 2014 12:16:22 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0MCGLEE030688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 22 Jan 2014 07:16:21 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0MCGJDZ011961; Wed, 22 Jan 2014 07:16:20 -0500 Message-ID: <52DFB692.2090104@redhat.com> Date: Wed, 22 Jan 2014 12:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Baruch Siach CC: gdb-patches@sourceware.org Subject: xtensa-config.c: missing defs.h include. References: <52D80DC6.5030703@redhat.com> <20140122044836.GL12751@tarshish> In-Reply-To: <20140122044836.GL12751@tarshish> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2014-01/txt/msg00850.txt.bz2 On 01/22/2014 04:48 AM, Baruch Siach wrote: > Hi Pedro, > > On Thu, Jan 16, 2014 at 04:50:14PM +0000, Pedro Alves wrote: >> On 01/16/2014 01:02 PM, Baruch Siach wrote: >>> On 64 bit hosts unsigned long is 64 bit. Use uint32_t instead. >>> >>> * xtensa-tdep.h (xtensa_elf_greg_t): Change type to uint32_t >> >> Missing period. >> >> OK (and obvious). > > Should I resend? No need. I'll push tweak and push it, but ... > > baruch > >>> --- >>> gdb/xtensa-tdep.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/gdb/xtensa-tdep.h b/gdb/xtensa-tdep.h >>> index 968b9d2916b7..d7ba5628e42a 100644 >>> --- a/gdb/xtensa-tdep.h >>> +++ b/gdb/xtensa-tdep.h >>> @@ -84,7 +84,7 @@ typedef enum >>> /* Xtensa ELF core file register set representation ('.reg' section). >>> Copied from target-side ELF header . */ >>> >>> -typedef unsigned long xtensa_elf_greg_t; >>> +typedef uint32_t xtensa_elf_greg_t; >>> >>> typedef struct >>> { >>> > ... this actually doesn't build. gcc -g3 -O0 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o xtensa-tdep.o -MT xtensa-tdep.o -MMD -MP -MF .deps/xtensa-tdep.Tpo ../../src/gdb/xtensa-tdep.c In file included from ../../src/gdb/xtensa-config.c:23:0: ../../src/gdb/xtensa-tdep.h:87:1: error: unknown type name ‘uint32_t’ I'm applying this fix first: --------- xtensa-config.c: missing defs.h include. All .c files must start by including defs.h. 2014-01-22 Pedro Alves * xtensa-config.c: Include defs.h. --- gdb/ChangeLog | 4 ++++ gdb/xtensa-config.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index caed724..107ed98 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2014-01-22 Pedro Alves + + * xtensa-config.c: Include defs.h. + 2014-01-22 Joel Brobecker * common/common-utils.h: Add "ARI:" comment beside __func__ diff --git a/gdb/xtensa-config.c b/gdb/xtensa-config.c index 19a33bb..345b334 100644 --- a/gdb/xtensa-config.c +++ b/gdb/xtensa-config.c @@ -17,6 +17,8 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ +#include "defs.h" + #define XTENSA_CONFIG_VERSION 0x60 #include "xtensa-config.h" -- 1.7.11.7