From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 1238A3849AE5 for ; Fri, 19 Apr 2024 16:30:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1238A3849AE5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1238A3849AE5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713544220; cv=none; b=oK/Ooo4MiyTBADnRebYq8LLc+jObVifH7XnAtYVpv9LqDCG41F52s4xvoHsL8XyagtuO9ZWnVUKDcRrUPJ00pm9k69In7iphfeMId3DVyaLYZXnKeR7M1vtJn/QhvO4Hlfpf/pv2l/u7evQJg6UXOoIJYPXhTFAvy/PLg16yrrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713544220; c=relaxed/simple; bh=TRmyOJSKzFGz6eS312KqLokr7kqAr8bpqFqg+t+P8tQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=XehytW6ncfxA7gpTzmCT8Kn+IIBiJZw7awLMlXogLRXVi6GDVQgvLN9fCopNpMAiSqx7t16thtDDGZxlBELDIgMG1Kf2ZGNqOQdM9GxhLI8K0RipJidSunOdTcGVrH4JxAHnzVkUwMXKQgidf2KOSruFZ403tM/hBsYczNw/tgE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 952B83796A; Fri, 19 Apr 2024 16:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713544213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3RAQ44Qngv7EOhjirK36isoV/s/mrx05cS94wyQNUI=; b=Hh5jx7PY6TwbjIj69drlGvyie2/ncRzTT5oRamnA07zkhSImCDQ/viwIkyPq2BWBIiVPCc d/D2OVnCcau8BZgZ1SnbHGISLhskfO8DyGYOFy3adKkKw73bNcVLG9xDD+E1LEWypYv6Mh cPJFHYVovRYf0AfbYnpHqlXUnXpfCO4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713544213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3RAQ44Qngv7EOhjirK36isoV/s/mrx05cS94wyQNUI=; b=EqTHD4lz2fYyAUQVjjmnDbw7PdLgNjwftXgBDfiqLbETxc3t9vcfZKV21gp/iAA26H6LH+ dRfQkBzhCiOkFHAw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Hh5jx7PY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=EqTHD4lz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1713544213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3RAQ44Qngv7EOhjirK36isoV/s/mrx05cS94wyQNUI=; b=Hh5jx7PY6TwbjIj69drlGvyie2/ncRzTT5oRamnA07zkhSImCDQ/viwIkyPq2BWBIiVPCc d/D2OVnCcau8BZgZ1SnbHGISLhskfO8DyGYOFy3adKkKw73bNcVLG9xDD+E1LEWypYv6Mh cPJFHYVovRYf0AfbYnpHqlXUnXpfCO4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1713544213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3RAQ44Qngv7EOhjirK36isoV/s/mrx05cS94wyQNUI=; b=EqTHD4lz2fYyAUQVjjmnDbw7PdLgNjwftXgBDfiqLbETxc3t9vcfZKV21gp/iAA26H6LH+ dRfQkBzhCiOkFHAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7EB1D13687; Fri, 19 Apr 2024 16:30:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DYCbHRWcImZRFQAAD6G6ig (envelope-from ); Fri, 19 Apr 2024 16:30:13 +0000 Message-ID: <52bbb92c-5bf1-4c1f-a89c-6de46be82dd5@suse.de> Date: Fri, 19 Apr 2024 18:30:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix random dejagnu test abort with simulator target To: Bernd Edlinger , "gdb-patches@sourceware.org" References: <140d448b-56cf-4cbc-88c8-e77573797179@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-4.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[hotmail.de,sourceware.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[hotmail.de]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 952B83796A X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -4.50 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/19/24 16:19, Bernd Edlinger wrote: > On 4/19/24 15:26, Tom de Vries wrote: >> On 4/19/24 12:49, Bernd Edlinger wrote: >>> This is probably a dejagnu issue with the gdb testsuite >>> when a simulator target is used.  I observed random >>> testrun aborts with dejagnu 1.6.2-1 from ubuntu 20.04 >>> The problem starts when the test case gdb.base/sigwinch-notty.exp >>> tries to execute "sleep", although that is impossible with a >>> simulator.  And for unknown reason the test case completes >>> (with errors) before the "after 1000" block is run. >>> >>> Then in a totally different test this happens with 50% likelihood: >>> >>> ERROR: (DejaGnu) proc "bgerror {can't read "gdb_pid": no such variable}" does not exist. >>> The error code is TCL LOOKUP COMMAND bgerror >>> The info on the error is: >>> invalid command name "bgerror" >>>      while executing >>> "::tcl_unknown bgerror {can't read "gdb_pid": no such variable}" >>>      ("uplevel" body line 1) >>>      invoked from within >>> "uplevel 1 ::tcl_unknown $args" >>> >>>                  === gdb Summary === >>> >>>   # of expected passes            30815 >>>   # of unexpected failures        241 >>>   # of expected failures          3 >>>   # of known failures             23 >>>   # of unresolved testcases       241 >>>   # of untested testcases         96 >>>   # of unsupported tests          532 >>>   # of paths in test names        1 >>> >>> So the whole test run is aborted in the middle. >>> >>> This patch should fix the issue. >>> --- >>>   gdb/testsuite/gdb.base/sigwinch-notty.exp | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/gdb/testsuite/gdb.base/sigwinch-notty.exp b/gdb/testsuite/gdb.base/sigwinch-notty.exp >>> index cef21c07c59..0f70f0978d2 100644 >>> --- a/gdb/testsuite/gdb.base/sigwinch-notty.exp >>> +++ b/gdb/testsuite/gdb.base/sigwinch-notty.exp >>> @@ -21,7 +21,7 @@ require {!target_info exists gdb,nosignals} >>>     # The testfile relies on "run" from the command line, so only works >>>   # with "target native". >>> -if { [target_info gdb_protocol] != "" } { >>> +if { [target_info gdb_protocol] != "" || [target_info is_simulator] != ""} { >>>       return >>>   } >>> >> >> Hi Bernd, >> >> thanks for the report and patch. >> >> [ I ran the test-case using make-check-all.sh, and ran into trouble with host/target board local-remote-host-native. >> >> I added some debugging here: >> ... >>  verbose -log "gdb_spawn_id=$gdb_spawn_id" >>  verbose -log "gdb_pid=$gdb_pid" >> +verbose -log "gdb_pid: [exec ps -p $gdb_pid]" >> ... >> and first ran with the default target board unix: >> ... >> gdb_spawn_id=exp6 >> gdb_pid=28288 >> gdb_pid:   PID TTY          TIME CMD >> 28288 pts/3    00:00:00 notty-wrap >> ... >> and then with host+target local-remote-host-native: >> ... >> gdb_spawn_id=exp6 >> gdb_pid=27827 >> gdb_pid:   PID TTY          TIME CMD >> 27827 pts/3    00:00:00 ssh >> ... >> >> Which is basically the remote host variant of what's explained here for remote target: >> ... >> proc can_spawn_for_attach { } { >>     # We use exp_pid to get the inferior's pid, assuming that gives >>     # back the pid of the program.  On remote boards, that would give >>     # us instead the PID of e.g., the ssh client, etc. >>     if {[is_remote target]} { >>         verbose -log "can't spawn for attach (target is remote)" >>         return 0 >>     } >> ... >> >> Anyway, this can be fixed using: >> ... >> -if { [target_info gdb_protocol] != "" } { >> +if { [target_info gdb_protocol] != "" || [is_remote host] } { >> ... >> ] >> >> Back to the problem you reported. >> >> I wonder about using gdb_spawn without checking for the result.  Does it still reproduce if we bail out when gdb_spawn fails? >> > >> If so, can you show the actual gdb.log for the test-case? >> > > Sure, > > testcase /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sigstep.exp completed in 0 seconds > Running /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sigwinch-notty.exp ... > Executing on build: rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sigwinch-notty (timeout = 300) > builtin_spawn -ignore SIGHUP rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sigwinch-notty^M > builtin_spawn /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/lib/notty-wrap /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../gdb/gdb -nw -nx -q -iex set height 0 -iex set width 0 -data-directory /home/ed/gnu/binutils-build-riscv-1/gdb/data-directory -ex show editing -ex run --args sleep 3^M > gdb_spawn_id=exp9 > gdb_pid=79294 > ^M > warning: A handler for the OS ABI "GNU/Linux" is not built into this configuration^M > of GDB. Attempting to continue with the default riscv settings.^M > ^M > Reading symbols from sleep...^M > (No debugging symbols found in sleep)^M > Editing of command lines as they are typed is off.^M > Don't know how to run. Try "help target".^M OK, I see now. We spawn gdb on host to spawn sleep on target. So I get to: ... # The test-case relies on "run" from the command line, so it only works # with "target native", so we need host == target. # # The test-case uses "exp_pid -i $gdb_spawn_id" which doesn't work with # remote host, so we need build == host. # # In other words, we need build == host == target. require {!is_remote host} {!is_remote target} # Check that we have "target native" as opposed to native-gdbserver etc. require {string equal [target_info gdb_protocol] ""} ... Having said that, I'm not sure if that addresses your problem, since I don't have experience with simulator setups. Perhaps "require isnative" is also necessary for simulators? That proc seems to check for target triplet == build triplet, while I think we're more interested in target triplet == host triplet, but it may be a sufficient proxy. Thanks, - Tom > (gdb) FAIL: gdb.base/sigwinch-notty.exp: wait for sleep exit > GDB process exited with wait status 79294 exp9 0 0 > PASS: gdb.base/sigwinch-notty.exp: wait for gdb exit > testcase /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sigwinch-notty.exp completed in 0 seconds > Running /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sizeof.exp ... > Executing on build: rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sizeof (timeout = 300) > builtin_spawn -ignore SIGHUP rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sizeof^M > Executing on host: riscv-unknown-elf-gcc -fno-stack-protector -fdiagnostics-color=never -c -g -o /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sizeof/sizeof0.o /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sizeof.c (timeout = 300) > builtin_spawn -ignore SIGHUP riscv-unknown-elf-gcc -fno-stack-protector -fdiagnostics-color=never -c -g -o /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sizeof/sizeof0.o /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sizeof.c^M > > [and a few 1000 lines later] > > uiltin_spawn -ignore SIGHUP rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/so-impl-ld^M > UNSUPPORTED: gdb.base/so-impl-ld.exp: require failed: allow_shlib_tests > testcase /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/so-impl-ld.exp completed in 0 seconds > Running /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/solib-abort.exp ... > Executing on build: rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/solib-abort (timeout = 300) > builtin_spawn -ignore SIGHUP rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/solib-abort^M > ERROR: (DejaGnu) proc "bgerror {can't read "gdb_pid": no such variable}" does not exist. > The error code is TCL LOOKUP COMMAND bgerror > The info on the error is: > invalid command name "bgerror" > while executing > "::tcl_unknown bgerror {can't read "gdb_pid": no such variable}" > ("uplevel" body line 1) > invoked from within > "uplevel 1 ::tcl_unknown $args" > > === gdb Summary === > > # of expected passes 30817 > # of unexpected failures 241 > # of expected failures 3 > # of known failures 23 > # of unresolved testcases 241 > # of untested testcases 96 > # of unsupported tests 527 > # of paths in test names 1 > Executing on host: /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../gdb/gdb -nw -nx -q -iex "set height 0" -iex "set width 0" -data-directory /home/ed/gnu/binutils-build-riscv-1/gdb/data-directory --version (timeout = 300) > builtin_spawn -ignore SIGHUP /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../gdb/gdb -nw -nx -q -iex set height 0 -iex set width 0 -data-directory /home/ed/gnu/binutils-build-riscv-1/gdb/data-directory --version^M > GNU gdb (GDB) 15.0.50.20240419-git^M > Copyright (C) 2024 Free Software Foundation, Inc.^M > License GPLv3+: GNU GPL version 3 or later ^M > This is free software: you are free to change and redistribute it.^M > There is NO WARRANTY, to the extent permitted by law.^M > /home/ed/gnu/binutils-build-riscv-1/gdb/gdb version 15.0.50.20240419-git -nw -nx -q -iex "set height 0" -iex "set width 0" -data-directory /home/ed/gnu/binutils-build-riscv-1/gdb/data-directory > > looks like this is the spawned gdb? > > Thanks > Bernd.