From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 015903858C50 for ; Tue, 12 Sep 2023 17:41:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 015903858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 38CHfBBx007451 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 13:41:16 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 38CHfBBx007451 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1694540476; bh=kQjmsNEqfs2wWtE2umG2JO5UJFl/9C5n8u6SDjBZhEs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DcereP0ScEpKEWlRtMTDJB83jPbR4EHPJC5rj68CKKHHUpIQBX9l5ZKHg4hDZKQYb aUjZlJdGT9tCrbFNgMV9izMuDraPSfvXCwDqDu1tGDCg4Pvk+nNvDhRHGzmaYzxAJk FeA+PcBMBQ9rXk2mLQklbx8vs8y8kQndLGm0hm+8= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 776501E092; Tue, 12 Sep 2023 13:41:11 -0400 (EDT) Message-ID: <52be463f-cd1b-4622-86a7-d60343bd30a7@polymtl.ca> Date: Tue, 12 Sep 2023 13:41:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 20/21] gdb: make set_top_level_interpreter a method of struct ui Content-Language: fr To: Andrew Burgess , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20230908190227.96319-1-simon.marchi@efficios.com> <20230908190227.96319-21-simon.marchi@efficios.com> <8734zjk57w.fsf@redhat.com> From: Simon Marchi In-Reply-To: <8734zjk57w.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 12 Sep 2023 17:41:11 +0000 X-Spam-Status: No, score=-3037.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> diff --git a/gdb/ui.c b/gdb/ui.c >> index 2db899eb9c31..ec74cc91cd21 100644 >> --- a/gdb/ui.c >> +++ b/gdb/ui.c >> @@ -223,6 +223,21 @@ ui::set_current_interpreter (interp *interp, bool top_level) >> >> /* See ui.h. */ >> >> +void >> +ui::set_top_level_interpreter (const char *name) >> +{ >> + /* Find it. */ >> + struct interp *interp = this->lookup_interp (name); >> + >> + if (interp == NULL) > > s/NULL/nullptr/ This is code that is being moved, but since this is a harmless and non-behavioral change, I'll include it here. Thanks, Simon