From: Simon Marchi <simon.marchi@polymtl.ca>
To: Alan Modra <amodra@gmail.com>, binutils@sourceware.org
Cc: gdb-patches@sourceware.org
Subject: Re: readelf: report DF_1_PIE as "Position Independent Executable"
Date: Fri, 11 Jun 2021 10:48:02 -0400 [thread overview]
Message-ID: <52d2dbe1-5328-d1ae-31b0-f77a18af8b14@polymtl.ca> (raw)
In-Reply-To: <YMN2k6JN2rMw8JqG@bubble.grove.modra.org>
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index d8c684c7238..a317781dafe 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -6078,7 +6078,7 @@ proc exec_is_pie { executable } {
> if { $res != 0 } {
> return -1
> }
> - set res [regexp -line {^[ \t]*Type:[ \t]*DYN \(Shared object file\)$} \
> + set res [regexp -line {^[ \t]*Type:[ \t]*DYN \((Position Independent Executable|Shared object) file\)$} \
> $output]
> if { $res == 1 } {
> return 1
Props for finding this place that needed to be updated. That change is
ok on the GDB side.
Grammar nit: I'm not a native english speaker and I don't know how that
rule would be called, but I think that an hyphen would technically be
required between Position and Independent (Position-Independent)?
Simon
next prev parent reply other threads:[~2021-06-11 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 14:43 Alan Modra
2021-06-11 14:48 ` Simon Marchi [this message]
2021-06-12 0:24 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52d2dbe1-5328-d1ae-31b0-f77a18af8b14@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).