From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 38ED2396E848;
 Fri, 11 Jun 2021 14:48:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38ED2396E848
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15BEm2xr002002
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Fri, 11 Jun 2021 10:48:07 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15BEm2xr002002
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id C46571E813;
 Fri, 11 Jun 2021 10:48:02 -0400 (EDT)
Subject: Re: readelf: report DF_1_PIE as "Position Independent Executable"
To: Alan Modra <amodra@gmail.com>, binutils@sourceware.org
Cc: gdb-patches@sourceware.org
References: <YMN2k6JN2rMw8JqG@bubble.grove.modra.org>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <52d2dbe1-5328-d1ae-31b0-f77a18af8b14@polymtl.ca>
Date: Fri, 11 Jun 2021 10:48:02 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YMN2k6JN2rMw8JqG@bubble.grove.modra.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 11 Jun 2021 14:48:03 +0000
X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2021 14:48:10 -0000

> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index d8c684c7238..a317781dafe 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -6078,7 +6078,7 @@ proc exec_is_pie { executable } {
>      if { $res != 0 } {
>  	return -1
>      }
> -    set res [regexp -line {^[ \t]*Type:[ \t]*DYN \(Shared object file\)$} \
> +    set res [regexp -line {^[ \t]*Type:[ \t]*DYN \((Position Independent Executable|Shared object) file\)$} \
>  		 $output]
>      if { $res == 1 } {
>  	return 1

Props for finding this place that needed to be updated.  That change is
ok on the GDB side.

Grammar nit: I'm not a native english speaker and I don't know how that
rule would be called, but I think that an hyphen would technically be
required between Position and Independent (Position-Independent)?

Simon