From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12162 invoked by alias); 20 Feb 2014 13:18:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12088 invoked by uid 89); 20 Feb 2014 13:18:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2014 13:18:27 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1KDIPaw006424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Feb 2014 08:18:26 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1KDIOHX004440; Thu, 20 Feb 2014 08:18:25 -0500 Message-ID: <530600A0.3060600@redhat.com> Date: Thu, 20 Feb 2014 13:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 6/8] Use new to_xfer_partial interface in ctf and tfile target References: <1392185152-21220-1-git-send-email-yao@codesourcery.com> <1392185152-21220-7-git-send-email-yao@codesourcery.com> In-Reply-To: <1392185152-21220-7-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00631.txt.bz2 On 02/12/2014 06:05 AM, Yao Qi wrote: > +/* Read from mappable read-only sections of BFD executable files. > + Similar to exec_read_only_xfer_partial, but return > + TARGET_XFER_E_UNAVAILABLE is data is unavailable. */ Typo: s/is data/if data/ > + > +extern enum target_xfer_status > + section_table_xfer_available_memory (gdb_byte *readbuf, ULONGEST offset, > + ULONGEST len, ULONGEST *xfered_len); The comment on function names I made on a previous patch applies here too. This only reads, so instead: extern enum target_xfer_status section_table_read_available_memory (gdb_byte *readbuf, ULONGEST offset, ULONGEST len, ULONGEST *xfered_len); or: extern enum target_xfer_status section_table_read_partial_available_memory (gdb_byte *readbuf, ULONGEST offset, ULONGEST len, ULONGEST *xfered_len); -- Pedro Alves