From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 33CAB38460A2 for ; Sun, 2 May 2021 00:39:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 33CAB38460A2 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1420dQC0029480 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 1 May 2021 20:39:31 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1420dQC0029480 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 295201E01F; Sat, 1 May 2021 20:39:26 -0400 (EDT) Subject: Re: [PATCH] gnulib: import getline To: Mike Frysinger , gdb-patches@sourceware.org References: <20210501220936.30972-1-vapier@gentoo.org> From: Simon Marchi Message-ID: <533969a7-d2fe-cdbd-40dc-e77eab30a469@polymtl.ca> Date: Sat, 1 May 2021 20:39:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210501220936.30972-1-vapier@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 2 May 2021 00:39:26 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 May 2021 00:39:41 -0000 On 2021-05-01 6:09 p.m., Mike Frysinger via Gdb-patches wrote: > We use getline in sim today which breaks on older systems that are > compliant with the latest POSIX standard. I can't really parse that sentence. Using getline doesn't work on older systems, because those older systems are compliant with the latest POSIX standard? Huh? Wouldn't being compliant with the latest POSIX standard be a good thing? Could you add to the commit message a description of what actual problem you faced that motivated you to do this change, maybe say which particular system you had a problem with? Simon