From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2053.outbound.protection.outlook.com [40.107.104.53]) by sourceware.org (Postfix) with ESMTPS id 29C4E385843E for ; Fri, 8 Jul 2022 11:36:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 29C4E385843E ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bczm9aPA9DyyUx9SYKrPGoisPHO/UEr7IK0jZQ9UpXAQA3Af2RQBIUprW7VGzbWhwMRMSYhNdJX5553jxduUfVWaiEDhQCuvrkuAQvdTLQXQow9DocGGZOG0uU6mfrgcUlLRofGnqe+xR7oDJa5AP/C3z0TFxgU6nDIRVjUtqL89HOT1kxpDvl5VHABzJgi8YuVxHe2xn63rGxZcDQpO9wh3/mFuYnUjXHBaT3Jfz01raZOqIj6dGDT7HteoGda/EkNnIEQjmuDvgcQp2Aq8f4VpJfO7pT1tZZ1jShxPzK6/VTGfJLUWl0XKgl/UZIjJ1B+Zw610eT8O+XbM21NrZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yN4HTawAE+Dobs25aPUccuhGKoGJnuOioWFAF2idQvU=; b=b6e4Wu1mTk8pj+a/g3PpQEw678DmCAz6BEa9xFJ6DWy9qqvv+vx+N6SiJhO0KRS1wmkxI6qofL/cmn9qBc/ne9yuFRGD0hv/SlbNuH5ooKEcsovvxnibPs8cy+vcH6QEygfpCB8j4VSCz/D02TuZ6q064MmiRqQDCwyVKOrCC9DZVLnb0bk7b4MJtGfHGBHHqoQRXn4tKCLufhed0fqec3Enf32RhRH8EPq0/IdRzxOFdv/d+qLJ9XEL2N6YFPMdLx+2ypomthPJ6jKlk2Dj20F9nrb8Blk9MFLU4qmwYNTBA9j5lIWKyRC4YnjMjWp6Hg5ZidDFpWQeL0kWgbAiqg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6PR02CA0006.eurprd02.prod.outlook.com (2603:10a6:20b:6e::19) by AM7PR08MB5383.eurprd08.prod.outlook.com (2603:10a6:20b:102::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Fri, 8 Jul 2022 11:36:19 +0000 Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::b9) by AM6PR02CA0006.outlook.office365.com (2603:10a6:20b:6e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 11:36:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 11:36:19 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Fri, 08 Jul 2022 11:36:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 03d3d1acad751535 X-CR-MTA-TID: 64aa7808 Received: from 8bfb6950b9ca.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 084831C7-2443-4A0A-A236-E5411AC9316A.1; Fri, 08 Jul 2022 11:36:12 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8bfb6950b9ca.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 11:36:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IWtiTIVYIpz2z09xyMx2Q6GFez7NEWT3DvCDUgaVNjYlkT4BBBKvoAnzWnUJjjNv6PWZMp+tWM0jx79ewQWEJrp5V+NRsko3hSimWFvuPz+LwmWiHLJZsQfqixRSCSI9JnlAAX4nZfaLN7BJz7cNvvbzIujQHuZ0X9ANrPD2QgFoukfsaOpK3OrISaL9S3EZslI7dYEQnfqAskFLnbjMzrn5YGFgxYy7qUimZrERmoV2B+WHqJ5dMqFmYx8s250gefAmqMgQMzqvqyJZOZOFYK9LWA+nGOG5EQuATZLalG4IYnPn/QVFPtstaqrQxP7Jn2wGIAxnDFjlgpjtLSLI6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yN4HTawAE+Dobs25aPUccuhGKoGJnuOioWFAF2idQvU=; b=O/aCw7plc+3eQvmIwr2Q19ZhVVEbDgwOPKVoleQpDxcuOYK6dXEEJ5sX51rn2nMRM3L6LxwB+PCP3iDUX94TCjlXE1ez8PQWVwfntlhVFvGN/6XQ8P1HmKbOKoWOV4iuKfoucgOLdNTYsL0ZaTexHdAMpGOQgy9M8C3+SqDB0CkbqTZ7XIDBTiU7gXVMHrCtzTOMbQlba5gIeV8GesEGAJIp9Cp3ML0slXKcrct2Z2cQR9N7bTi4vQVISrd7F23dS3F3l52WUZVvXoIkOLVy0FLhokMPudGzQNvpYukvdVjPmSoGmxlDvlr+H8RCh4OfE6ujHp17OEN/4ZknCkVQrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VE1PR08MB4765.eurprd08.prod.outlook.com (2603:10a6:802:a5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 11:36:08 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::1cda:8ca1:6353:572c]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::1cda:8ca1:6353:572c%4]) with mapi id 15.20.5417.015; Fri, 8 Jul 2022 11:36:08 +0000 Message-ID: <533c9a59-1755-f260-3c56-2c68003e25d6@arm.com> Date: Fri, 8 Jul 2022 12:36:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] [AArch64] Fix removal of non-address bits for PAuth Content-Language: en-US To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20220705140037.135012-1-luis.machado@arm.com> <20220706113857.a6gfmmlaeprg5uyq@ubuntu.lan> From: Luis Machado In-Reply-To: <20220706113857.a6gfmmlaeprg5uyq@ubuntu.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0394.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::22) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 0d663be4-1b3e-4f43-ccdd-08da60d613a6 X-MS-TrafficTypeDiagnostic: VE1PR08MB4765:EE_|AM5EUR03FT013:EE_|AM7PR08MB5383:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /pXlVzLsKeSoIrHh7UXCFaZmL0F83Eg0vdT6upQvxEJklzI7YDaEehYXysybOgUuJQ8alAM2KX2fTHHABkNTwSnb/A73Z9nCUIwocuoR4PIWVPlTrnythiexpkUSZSvqNEA6hPmUtkv07octcf8mSBIR08ODmVMaGGQjePmOL4DU5QPNq9xesKRK1JP0p7IvJUOI7vtq/N7iK3pDrnnRXTyDt3xzt0BI1KjWyJLfriE46tQx7PIC0GpP7lLv38DMGW9IYsHGXdMZkF0q4jgt5fGaUku9hF57iUQFGe5e9e3jnfkK5sAjX4aK9h2HhrXz83XvWRBkwfyGcEhF9+pOu1T9FWDitWO3VC/IOeCY3f2E1Bm9iM5CYZq1V0YipXsQJEdO9NHjvkuWyca4Ijc2woyFOCYBy0KlWO+8RQvCdFh9dlhmF+j88EGh8BkdBNw2Wqso9loxokAQxc8EMq8tqKIP1X6KyQQGhsidz1vxSuJ7xWX9aHaPoKfHGJrmSKlhRH9fvbJT+y15OXU0kr3GLiJDTkdPfYN/mjDP07flz2bnW6sAJQ4iTatIzxBgGgm6SBTBHu3N0DNQUNvq+b8WmWyv0F/6/8MuTudG3n0Qc+rbPEd/snwu9FMwfged1VVUKelOrDLyJHHsG0Zn4SxbzLqxYq5zFCS8Exx1oPcP9rP5eeeJiKHKdscma079G5Tunvv96016a7arzxd47Gx1okl1f8PMNIvWAm5VmoU8QsDaFVhNnbGt/fiSN4bhgtQs7CKeYyTUfrJXaQhqWKkb7SE9JQUTC/An2U/8hf1a4oM9NyybxlQYrtDl9XTlk5Vv2vANAWTNqyz2jEQbtIpSccBpKqxRqM0U2TMai+2ijGo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(39860400002)(376002)(346002)(136003)(396003)(41300700001)(2906002)(6916009)(186003)(2616005)(36756003)(31686004)(6506007)(53546011)(4744005)(316002)(5660300002)(44832011)(66946007)(66556008)(8676002)(6486002)(66476007)(4326008)(6512007)(8936002)(86362001)(478600001)(31696002)(38100700002)(83380400001)(26005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4765 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 705e1f16-d2e2-442a-8902-08da60d60ced X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CcpvhQtmzrGKAUk2ggPTgfIEPziUbTmkW8Yi6RQIqKp2iU3FHmwgJsWM3wPvPh4brq4AJRvBF1oirJfZEvOtuCt0lqO2918SaXe3vJoVJ3yiliniee7ANxmAE8I4t0wAj1B0Janq0cSnTGf9KyVf1QGDU6U3Fdc6K7hnBfb8x6qPwHI/jnXIa62NLIvEirpI97NqJJIRZ+htRZ+AVBYIIjAtGgvXKH2c0Vi3XDd3EX9/xImYxAQ3ep6+1agtMPM7/5tajoEHjOVZjESJ9yjPIfcQYRpBSCln7grxg+mSBup/OWlBFk2cjXa0SY3p+a+Wt9bRRm78p0iya0BHJBd6WN4lHolEs9rCU5AftMLG99RL7iTP7beb55fCX/NaDb6xyb1BdjWkiehs0BXSGpugRHoxEIjGJbpM0SADoo4Y51+6svH0B86kmjlUrxh4xcZZZGuHP2uFFY7+pWMKKBSZJXvUkVe37TbzGDb+Z0LbVKd0YONMXdBSjRtQb9A/iVPnOniX5KfuaZmih4LU8xxu4epVuvZjLyG55qbK7q28gGYkZxpmmGoP23pbqyHi4ohU9DbLIew1pFgO8vagjZrXDYWx800zza4EwQWmli92D/Dokc8n9PVGe2kvqPIOONEGao6R6byqaaKTV5gZ1UdZvIoC+3HLAPNR+89/8SLsLHqQC0ZVmvPHTJdyNqXtax4HZZbNNAAvOVUlXYeFichtS1aNo+Hjo8eE8ORcIO3ZPcZ5P0vb7256Kf0CeC8NW10ZNbaP7SOYS+FQ+mFM3/GKymgw652aWy6rk3z6CyrCK0np2RCtsFWvMWXAp/zxOX3K+htu11xxhJlzXcUJmzQjj7wFsRX/qYuDVE5kwsFnEwE= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(36840700001)(40470700004)(46966006)(70586007)(81166007)(26005)(4744005)(31686004)(41300700001)(336012)(53546011)(40460700003)(6506007)(186003)(2906002)(47076005)(36756003)(82740400003)(356005)(316002)(70206006)(83380400001)(6486002)(8936002)(31696002)(6862004)(82310400005)(8676002)(478600001)(5660300002)(36860700001)(6512007)(86362001)(2616005)(44832011)(4326008)(40480700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 11:36:19.4659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d663be4-1b3e-4f43-ccdd-08da60d613a6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5383 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2022 11:36:24 -0000 On 7/6/22 12:38, Lancelot SIX wrote: >> + >> +/* See arch/aarch64.h. */ >> + >> +CORE_ADDR >> +aarch64_remove_top_bytes (CORE_ADDR pointer, CORE_ADDR mask) > > Hi, > > Shouldn't this function be called aarch64_remove_top_bits (note the > s/bytes/bits)? This function does not work at the byte grain. > > It should! I think I had the TBI (top byte ignore) in mind and then byte was stuck in my head. Thanks, I'll update this. >> +{ >> + /* The VA range select bit is 55. This bit tells us if we have a >> + kernel-space address or a user-space address. */ >> + bool kernel_address = (pointer & VA_RANGE_SELECT_BIT_MASK)? true : false; > > You could drop the ternary operator by using > > bool kernel_address = (pointer & VA_RANGE_SELECT_BIT_MASK) != 0; > > which I find a "more canonical" way to write it, but I guess it is > mostly a matter of taste. Yeah. I don't mind either way.