From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16866 invoked by alias); 5 May 2014 03:52:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16852 invoked by uid 89); 5 May 2014 03:51:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 May 2014 03:51:58 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Wh9wY-0003fw-4f from Yao_Qi@mentor.com ; Sun, 04 May 2014 20:51:54 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 4 May 2014 20:51:53 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Sun, 4 May 2014 20:51:52 -0700 Message-ID: <53670A4E.4010603@codesourcery.com> Date: Mon, 05 May 2014 03:52:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 3/4] Save traceframes in trace file and read data out from trace file. References: <1398665538-16580-1-git-send-email-yao@codesourcery.com> <1398665538-16580-4-git-send-email-yao@codesourcery.com> <53612431.6040704@redhat.com> In-Reply-To: <53612431.6040704@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00031.txt.bz2 On 05/01/2014 12:26 AM, Pedro Alves wrote: >> + gdb_test "tsave -ctf ${tracefile}.floats.ctf" \ > I trust this works even if "target ctf" isn't supported? Yes, we use generic file write/seek APIs to write ctf trace file, but use libbabeltrace to read from ctf trace file. Even "target ctf" isn't supported (libbabeltrace isn't used), GDB is still able to save in ctf format. Patches are pushed in. Thanks for the review. -- Yao (齐尧)